Closed
Bug 1243975
Opened 10 years ago
Closed 10 years ago
[e10s] Enable browser_webconsole_bug_632817.js in e10s
Categories
(DevTools :: Console, defect, P1)
DevTools
Console
Tracking
(e10s+, firefox47 fixed, firefox48 fixed)
RESOLVED
FIXED
Firefox 48
People
(Reporter: linclark, Assigned: bgrins)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
No description provided.
|
||
Updated•10 years ago
|
Blocks: e10s-tests
tracking-e10s:
--- → +
|
Assignee | |
Updated•10 years ago
|
Priority: -- → P1
|
|
Assignee | |
Comment 1•10 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/40465/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/40465/
Attachment #8732149 -
Flags: review?(lclark)
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
|
Reporter | |
Comment 2•10 years ago
|
||
Comment on attachment 8732149 [details]
MozReview Request: Bug 1243975 - Enable browser_webconsole_bug_632817.js in e10s;r=linclark
This seems to still be perma-orange on try, but lmk if I forgot to include something in the try push.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=766492be21cd
Attachment #8732149 -
Flags: review?(lclark) → review-
|
|
Assignee | |
Comment 3•10 years ago
|
||
(In reply to Lin Clark [:linclark] from comment #2)
> Comment on attachment 8732149 [details]
> MozReview Request: Bug 1243975 - Enable browser_webconsole_bug_632817.js in
> e10s;r=linclark
>
> This seems to still be perma-orange on try, but lmk if I forgot to include
> something in the try push.
>
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=766492be21cd
You are right, I missed one instance of `content.` outside of a ContentTask. Will push code change now, here's an ongoing try push (attempting to run just the webconsole folder with mach try): https://treeherder.mozilla.org/#/jobs?repo=try&revision=7fd310619f34
|
|
Assignee | |
Comment 4•10 years ago
|
||
Comment on attachment 8732149 [details]
MozReview Request: Bug 1243975 - Enable browser_webconsole_bug_632817.js in e10s;r=linclark
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40465/diff/1-2/
Attachment #8732149 -
Flags: review- → review?(lclark)
|
|
Reporter | |
Comment 5•10 years ago
|
||
Comment on attachment 8732149 [details]
MozReview Request: Bug 1243975 - Enable browser_webconsole_bug_632817.js in e10s;r=linclark
https://reviewboard.mozilla.org/r/40465/#review38021
LGTM!
Attachment #8732149 -
Flags: review?(lclark) → review+
|
|
||
Comment 7•10 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
|
||
Comment 8•10 years ago
|
||
| bugherder uplift | ||
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•