Closed Bug 1244030 Opened 8 years ago Closed 8 years ago

[porting][nexusplayer] add nexusplayer.xml

Categories

(Firefox OS Graveyard :: GonkIntegration, defect)

Product:
Firefox OS Graveyard
Component:
GonkIntegration
Platform:
x86
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: fatseng, Assigned: fatseng)

References

Details

Attachments

(1 file)

manifest PR
54 bytes, text/x-github-pull-request
gerard-majax
: review+
Details | Review 
      No description provided.
Attached file manifest PR — 
Add Nexus Player manifest
Attachment #8714252 - Flags: review?(lissyx+mozillians)
Assignee: nobody → fatseng
Status: NEW → ASSIGNED
Blocks: 1239938
Comment on attachment 8714252 [details] [review]
manifest PR

I don't understand why we use prebuilt kernel repo and not sources. Given we need to enable FANOTIFY, SECCOMP, ... ?
Attachment #8714252 - Flags: review?(lissyx+mozillians)
(In reply to Alexandre LISSY :gerard-majax from comment #2)
> Comment on attachment 8714252 [details] [review]
> manifest PR
> 
> I don't understand why we use prebuilt kernel repo and not sources. Given we
> need to enable FANOTIFY, SECCOMP, ... ?

I Forgot to check SECCOMP, will do it.
(In reply to Farmer Tseng[:fatseng] from comment #3)
> (In reply to Alexandre LISSY :gerard-majax from comment #2)
> > Comment on attachment 8714252 [details] [review]
> > manifest PR
> > 
> > I don't understand why we use prebuilt kernel repo and not sources. Given we
> > need to enable FANOTIFY, SECCOMP, ... ?
> 
> I Forgot to check SECCOMP, will do it.

Gecko would not boot at all without SECCOMP ... What is the status of this port ?
Flags: needinfo?(fatseng)
(In reply to Alexandre LISSY :gerard-majax from comment #4)
> (In reply to Farmer Tseng[:fatseng] from comment #3)
> > (In reply to Alexandre LISSY :gerard-majax from comment #2)
> > > Comment on attachment 8714252 [details] [review]
> > > manifest PR
> > > 
> > > I don't understand why we use prebuilt kernel repo and not sources. Given we
> > > need to enable FANOTIFY, SECCOMP, ... ?
> > 
> > I Forgot to check SECCOMP, will do it.
> 
> Gecko would not boot at all without SECCOMP ... What is the status of this
> port ?

In Nexus6 experience, Gecko can't boot without FANOTIFY.
Android Nexusplayer kernel enabled FANOTIFY.
Therefore, there is no problem for booting.
Flags: needinfo?(fatseng)
The kernel already enabled FANOTIFY but leaked to enable SECCOMP and SECCOMP_FILTER.
I will build kernel with them.
Blocks: 1239940
No longer blocks: 1239938
Attachment #8714252 - Flags: review?(lissyx+mozillians)
I enabled CONFIG_SECCOMP and CONFIG_SECCOMP_FILTER and re-built kernel image.
I modified nexusplayer.xml, re-direct to use our prebuilt kernel.
Attachment #8714252 - Flags: review?(lissyx+mozillians) → review+
Please help merge, Thanks.
Flags: needinfo?(lissyx+mozillians)
https://github.com/mozilla-b2g/b2g-manifest/commit/42444f6bab2141cad6276b12bde71ea523aca88b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: needinfo?(lissyx+mozillians)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: