Closed Bug 1244062 Opened 5 years ago Closed 5 years ago

Upgrade Firefox 47 to NSPR 4.12

Categories

(Firefox Build System :: General, defect)

47 Branch
defect
Not set
normal

Tracking

(firefox44 wontfix, firefox45+ fixed, firefox46 fixed, firefox47 fixed, firefox-esr38 wontfix)

RESOLVED FIXED
mozilla47
Tracking Status
firefox44 --- wontfix
firefox45 + fixed
firefox46 --- fixed
firefox47 --- fixed
firefox-esr38 --- wontfix

People

(Reporter: KaiE, Assigned: KaiE)

References

Details

Attachments

(1 file)

Let's create an NSPR 4.12 release in about two weeks.
Keywords: leave-open
That was a combined commit that landed NSPR_4_12_BETA2 and NSS_3_23_BETA2
Keywords: leave-open
[Tracking Requested - why for this release]:
It would be nice to upgrade NSPR on Firefox 45. The upgrade is small and seems better to do it now with copious beta testing rather than take it on the 45-ESR branch for 45.1 later (which we'll want to do to pick up the fix for bug 1174015).

NSPR 4.12 has been on Aurora and Nightly for a few weeks.
FYI, Aurora has been fixed with the commit from bug 1228410 comment 37, because the new NSPR was a precondition for landing NSS:
https://hg.mozilla.org/releases/mozilla-aurora/rev/7141f2426f66

On that day I had forgotten that we had this separate NSPR bug, sorry.
(In reply to Daniel Veditz [:dveditz] from comment #6)
> It would be nice to upgrade NSPR on Firefox 45. The upgrade is small and
> seems better to do it now with copious beta testing rather than take it on
> the 45-ESR branch for 45.1 later (which we'll want to do to pick up the fix
> for bug 1174015).

I concur.
https://hg.mozilla.org/mozilla-central/rev/05c436617515
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Kai, would you mind asking for an uplift to beta? Thanks
Flags: needinfo?(kaie)
Attached file nspr-for-45beta.txt
I recommend to uplift NSPR 4.12 to Firefox 45 beta.

The NSPR 4.12 has already been in use successfully on the Aurora 46 and m-c 47 branches without trouble.

The primary motivation is to fix memory allocation issues.

The other changes in NSPR 4.12 shall be safe and low risk.
- a new function was added, which isn't being used, and is therefore neutral
- everything else were build fixes for compatibility with additional platforms
Flags: needinfo?(kaie)
Attachment #8723556 - Flags: approval-mozilla-beta?
Assignee: nobody → kaie
Comment on attachment 8723556 [details]
nspr-for-45beta.txt

Need that for 45.
Attachment #8723556 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
kai: i guess you handle this as always :)
Flags: needinfo?(kaie)
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.