1244062 - Upgrade Firefox 47 to NSPR 4.12

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Kai Engert [:KaiE:]]

Let's create an NSPR 4.12 release in about two weeks.

Comment 1

[(not currently active) Ted Mielczarek]

Changes from 4.11 to 4.12:
http://hg.mozilla.org/projects/nspr/pushloghtml?fromchange=NSPR_4_11_RTM&tochange=NSPR_4_12_BETA1

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/44ab9df0cd78

Comment 3

[Kai Engert [:KaiE:]]

That was a combined commit that landed NSPR_4_12_BETA2 and NSS_3_23_BETA2

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/44ab9df0cd78

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/05c436617515

Comment 6

[Daniel Veditz [:dveditz]]

[Tracking Requested - why for this release]:
It would be nice to upgrade NSPR on Firefox 45. The upgrade is small and seems better to do it now with copious beta testing rather than take it on the 45-ESR branch for 45.1 later (which we'll want to do to pick up the fix for bug 1174015).

NSPR 4.12 has been on Aurora and Nightly for a few weeks.

Comment 7

[Kai Engert [:KaiE:]]

FYI, Aurora has been fixed with the commit from bug 1228410 comment 37, because the new NSPR was a precondition for landing NSS:
https://hg.mozilla.org/releases/mozilla-aurora/rev/7141f2426f66

On that day I had forgotten that we had this separate NSPR bug, sorry.

Comment 8

[Kai Engert [:KaiE:]]

(In reply to Daniel Veditz [:dveditz] from comment #6)
> It would be nice to upgrade NSPR on Firefox 45. The upgrade is small and
> seems better to do it now with copious beta testing rather than take it on
> the 45-ESR branch for 45.1 later (which we'll want to do to pick up the fix
> for bug 1174015).

I concur.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/05c436617515

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Kai, would you mind asking for an uplift to beta? Thanks

Comment 11

[Kai Engert [:KaiE:]]

Attachment: nspr-for-45beta.txt

I recommend to uplift NSPR 4.12 to Firefox 45 beta.

The NSPR 4.12 has already been in use successfully on the Aurora 46 and m-c 47 branches without trouble.

The primary motivation is to fix memory allocation issues.

The other changes in NSPR 4.12 shall be safe and low risk.
- a new function was added, which isn't being used, and is therefore neutral
- everything else were build fixes for compatibility with additional platforms

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8723556 [details]
nspr-for-45beta.txt

Need that for 45.

Comment 13

[Carsten Book [:Tomcat]]

kai: i guess you handle this as always :)

Comment 14

[Kai Engert [:KaiE:]]

https://hg.mozilla.org/releases/mozilla-beta/rev/bbe048ab30ad