Fix configure.in minimum requirement to NSS 3.21

RESOLVED FIXED

Status

Firefox Build System
General
RESOLVED FIXED
3 years ago
5 months ago

People

(Reporter: kaie, Assigned: kaie)

Tracking

45 Branch

Firefox Tracking Flags

(firefox44 fixed, firefox45 fixed, firefox46 fixed, relnote-firefox 44+)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
In bug 1211568, we forgot to bump the minimum NSS version requirement, 
when up upgraded to NSS 3.21

We should fix that for Firefox 45 and 46.

(Firefox 47 already uses 3.22 and has been fixed already in bug .)
(Assignee)

Comment 1

3 years ago
Created attachment 8713570 [details] [diff] [review]
patch v1 for aurora 46 and beta 45 (and potentially release 44)
Attachment #8713570 - Flags: review?(ted)
(Assignee)

Updated

3 years ago
Assignee: nobody → kaie
(Assignee)

Comment 2

3 years ago
Comment on attachment 8713570 [details] [diff] [review]
patch v1 for aurora 46 and beta 45 (and potentially release 44)

Linux distributions should be made aware that we require NSS 3.21 for building Firefox 44, 45 and 46.
Attachment #8713570 - Attachment description: patch v1 → patch v1 for aurora 46 and beta 45 (and potentially release 44)
Attachment #8713570 - Flags: approval-mozilla-release?
Attachment #8713570 - Flags: approval-mozilla-beta?
Attachment #8713570 - Flags: approval-mozilla-aurora?
Attachment #8713570 - Flags: review?(ted) → review+
status-firefox44: --- → affected
status-firefox45: --- → affected
status-firefox46: --- → affected
Comment on attachment 8713570 [details] [diff] [review]
patch v1 for aurora 46 and beta 45 (and potentially release 44)

Taking it for aurora & beta.
Should be in 45 beta 2.
Attachment #8713570 - Flags: approval-mozilla-beta?
Attachment #8713570 - Flags: approval-mozilla-beta+
Attachment #8713570 - Flags: approval-mozilla-aurora?
Attachment #8713570 - Flags: approval-mozilla-aurora+
(Assignee)

Comment 4

3 years ago
Hi Ryan, would you please be able to help me land that? If not I can try to do it later today. Thank you.
Flags: needinfo?(ryanvm)
302 to the sheriff in our TZ (Ryan is no longer doing that)
Flags: needinfo?(cbook)
https://hg.mozilla.org/releases/mozilla-aurora/rev/2bf5e0123345
https://hg.mozilla.org/releases/mozilla-beta/rev/4d96907bc1f0
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox45: affected → fixed
status-firefox46: affected → fixed
Flags: needinfo?(ryanvm)
Flags: needinfo?(cbook)
Resolution: --- → FIXED

Comment 7

3 years ago
Comment on attachment 8713570 [details] [diff] [review]
patch v1 for aurora 46 and beta 45 (and potentially release 44)

This seems like a safe ride-along in 44.0.1 release, Release44+
Attachment #8713570 - Flags: approval-mozilla-release? → approval-mozilla-release+

Comment 8

3 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-release/rev/f5b36c7a56c0
status-firefox44: affected → fixed
Adding a release note as this is part of 44.0.1. 
Wording: Require NSS 3.21 (with link to this bug)
relnote-firefox: --- → 44+

Updated

5 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.