Closed
Bug 1244069
Opened 9 years ago
Closed 9 years ago
Fix configure.in minimum requirement to NSS 3.21
Categories
(Firefox Build System :: General, defect)
Tracking
(firefox44 fixed, firefox45 fixed, firefox46 fixed, relnote-firefox 44+)
People
(Reporter: KaiE, Assigned: KaiE)
References
Details
Attachments
(1 file)
782 bytes,
patch
|
ted
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
ritu
:
approval-mozilla-release+
|
Details | Diff | Splinter Review |
In bug 1211568, we forgot to bump the minimum NSS version requirement,
when up upgraded to NSS 3.21
We should fix that for Firefox 45 and 46.
(Firefox 47 already uses 3.22 and has been fixed already in bug .)
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8713570 -
Flags: review?(ted)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → kaie
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8713570 [details] [diff] [review]
patch v1 for aurora 46 and beta 45 (and potentially release 44)
Linux distributions should be made aware that we require NSS 3.21 for building Firefox 44, 45 and 46.
Attachment #8713570 -
Attachment description: patch v1 → patch v1 for aurora 46 and beta 45 (and potentially release 44)
Attachment #8713570 -
Flags: approval-mozilla-release?
Attachment #8713570 -
Flags: approval-mozilla-beta?
Attachment #8713570 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
Attachment #8713570 -
Flags: review?(ted) → review+
Updated•9 years ago
|
Comment 3•9 years ago
|
||
Comment on attachment 8713570 [details] [diff] [review]
patch v1 for aurora 46 and beta 45 (and potentially release 44)
Taking it for aurora & beta.
Should be in 45 beta 2.
Attachment #8713570 -
Flags: approval-mozilla-beta?
Attachment #8713570 -
Flags: approval-mozilla-beta+
Attachment #8713570 -
Flags: approval-mozilla-aurora?
Attachment #8713570 -
Flags: approval-mozilla-aurora+
Assignee | ||
Comment 4•9 years ago
|
||
Hi Ryan, would you please be able to help me land that? If not I can try to do it later today. Thank you.
Flags: needinfo?(ryanvm)
Comment 5•9 years ago
|
||
302 to the sheriff in our TZ (Ryan is no longer doing that)
Flags: needinfo?(cbook)
Comment 6•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/2bf5e0123345
https://hg.mozilla.org/releases/mozilla-beta/rev/4d96907bc1f0
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: needinfo?(ryanvm)
Flags: needinfo?(cbook)
Resolution: --- → FIXED
Comment on attachment 8713570 [details] [diff] [review]
patch v1 for aurora 46 and beta 45 (and potentially release 44)
This seems like a safe ride-along in 44.0.1 release, Release44+
Attachment #8713570 -
Flags: approval-mozilla-release? → approval-mozilla-release+
Comment 8•9 years ago
|
||
bugherder uplift |
Comment 9•9 years ago
|
||
Adding a release note as this is part of 44.0.1.
Wording: Require NSS 3.21 (with link to this bug)
relnote-firefox:
--- → 44+
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•