124407 - Items on this page offset by the entire page

Status: RESOLVED WORKSFORME

(Core :: Layout, defect, P3)

Description

[Rob McMillin]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.8) Gecko/20020205
BuildID:    2002020511

Yeah, yeah, I know it's not a good, minimal page, but I'm working on it, okay? 
Anyway, the product items on this page are all off the page; you can *barely*
see the "Compare" button on the middle right, which should be on the left of the
BIG HONKIN' WHITE SPACE IN THE MIDDLE.  Obviously, works fine under Netscape
4.72 and MSIE <any version>|<any platform>.

Oh, sure, I know the HTML won't pass muster in any of the HTML
parsing/validation packages (it breaks tidy, for instance, and the W3C validator
as well); but even if I fix the more egregious "this tag can't be contained in
that tag" errors (I'll attach an HTML document with this fixed in a bit), it
still fails.

Reproducible: Always
Steps to Reproduce:
1. Go to the URL above
2. Bingo.


Actual Results:  See description, above.

Expected Results:  White space filled with products and prices.  Oof.

More coming, I promise.  I know what it's like to have **** bug reports --
really, I'm working on getting a better report together.  Also -- this bug has
been verified on 0.9.7 on Win2k and MacOS 9.0.

Comment 1

[Rob McMillin]

Attachment: Fixed HTML fromt the page listed

This fixes a few of the more egregious problems with the HTML given at the URL
earlier.  The remaining bugs are idle complaints of the "<img> lacks 'alt'
attribute" (who cares, we're only using it for spacing) and "<table> lacks
'summary' attribute" (ditto).  But we still see the same problem.

Comment 2

[Alfonso Martinez]

I still can't find the real reason, but the problem is related to the javascript
used to include all those banners (maybe some unclosed tag?). Removing all that
code fixes the layout.

Comment 3

[Amarendra Hanumanula]

  I could reproduce the bug on Win2k too. Initially when I load the given URL it 
does not show up all the products list, but when I resize the window it shows up 
the whole page. Might be javascript problem. 
Setting the Priority to P3.

Comment 4

[Rob McMillin]

FWIW, the tags are closed in the referent JavaScript.  But, yes, I've verified
that removing it definitely fixes the problem.

Comment 5

[Alfonso Martinez]

Attachment: More simplified testcase

This is a much more simplified testcase.

Now almost anything that I've tried to simplify it more fixes the layout. It's
a really strange bug.

Comment 6

[Alfonso Martinez]

This might be a regression as Kmeleon 0.6 displays the original page and the
testcase fine. The older Mozilla that I got installed is 0.9.7 and it has the bug.

Comment 7

[Rob McMillin]

Dude, you are my hero.  I've been on (a brief) vacation since Friday, so I
haven't had time to look in to this.  But I've seen this bug as far back as
Linux 0.9.6.

Comment 8

[Rob McMillin]

Attachment: Javascript snippet

Comment 9

[Rob McMillin]

Attachment: Slightly altered version of the simplified testcase

This time we put the JavaScript in a separate attachment to this bug so the ad
that causes this bug doesn't go out of rotation (shouldn't happen as this is
size-based, but you never know).

Comment 10

[Tom Mraz]

Strange, I don't see any problems with the last testcase. But the 'More
simplifed testcase' shows the buggy behaviour.

Comment 11

[Tom Mraz]

When I look at the 'More simplified testcase' in the DOM inspector it shows that
the <td> with the input button gets pushed out of the table in the layout (but
not in the DOM).

Comment 12

[Tom Mraz]

I now see the buggy behaviour even on the latest testcase but this time on
different machine with newer XFree (4.1.0). On the previous machine I have XFree
4.0.2.

Also nominating to 1.0 since I suspect this bug is affecting more pages which
use document.write().

Comment 13

[Tom Mraz]

Ah... I now see that it has nothing to do with the XFree version. 
Simply if you first open the Javascript snippet in browser window and then the
altered testcase, the bug doesn't show. So it's probably problem of time when
the snippet loads in the displayed page. If it loads after the tables have
loaded then it screws the layout. If it's loaded soon (from cache) it doesn't
screw it.

Comment 14

[Rob McMillin]

Two comments: first, the slightly modified test case is still reliably breaking
my browser (0.9.8, RedHat 7.2, XFree 4.1.0-15) regardless of load order. Second,
the JavaScript used here is generated by RealMedia's OpenAdStream product. See

http://www.realmedia.com/technology/technology.html

for the brochureware.

Comment 15

[R.K.Aa.]

*** Bug 127351 has been marked as a duplicate of this bug. ***

Comment 16

[Rob McMillin]

Looks like this works in 1.0.  Can you guys close this bug?

Comment 17

[tom.williams]

Looks great to me!  Great job!  :)

Peace...

Tom
(Mozilla end-user)

Comment 18

[Alfonso Martinez]

Resolving as Works for me. Win98, Mozilla 1.0RC3