1244092 - Windows build of mozilla-central fails on VS2015 with dist\include\nsIFrame.h(892): error C2127: 'descriptor': illegal initialization of 'constexpr' entity with a non-constant expression

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jukka Jylänki]

Attachment: build_log.txt

Building on VS2015 on Windows has begun failing in the past ~two weeks with the following errors

 0:26.66 Unified_cpp_editor_libeditor2.cpp
 0:26.66 d:\gecko-dev\obj-x86_64-pc-mingw32\dist\include\nsIFrame.h(892): error C2127: 'descriptor': illegal initialization of 'constexpr' entity with a non-constant expression
 0:26.66 d:\gecko-dev\obj-x86_64-pc-mingw32\dist\include\nsIFrame.h(893): error C2127: 'descriptor': illegal initialization of 'constexpr' entity with a non-constant expression
 0:26.66 d:\gecko-dev\obj-x86_64-pc-mingw32\dist\include\nsIFrame.h(895): error C2127: 'descriptor': illegal initialization of 'constexpr' entity with a non-constant expression
 0:26.66 d:\gecko-dev\obj-x86_64-pc-mingw32\dist\include\nsIFrame.h(896): error C2127: 'descriptor': illegal initialization of 'constexpr' entity with a non-constant expression
 0:26.66 d:\gecko-dev\obj-x86_64-pc-mingw32\dist\include\nsIFrame.h(898): error C2127: 'descriptor': illegal initialization of 'constexpr' entity with a non-constant expression
 0:26.66 d:\gecko-dev\obj-x86_64-pc-mingw32\dist\include\nsIFrame.h(903): error C2127: 'descriptor': illegal initialization of 'constexpr' entity with a non-constant expression
 0:26.66 d:\gecko-dev\obj-x86_64-pc-mingw32\dist\include\nsIFrame.h(912): fatal error C1903: unable to recover from previous error(s); stopping compilation
 0:26.66 Internal Compiler Error in c:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\amd64\cl.exe.  You will be prompted to send an error report to Microsoft later.

Full incremental build log attached.

Comment 1

[Jukka Jylänki]

fwiw I think the internal compiler error does not mean anything in this case, seems that the compiler trips up on itself after already trying to wind down the already failed compilation.

Comment 2

[Mats Palmgren (inactive)]

The line numbers corresponds to NS_DECLARE_FRAME_PROPERTY_DELETABLE declarations:
http://hg.mozilla.org/mozilla-central/annotate/8a3c5c9b1486/layout/generic/nsIFrame.h#l892

So I'm guessing this is a regression from bug 1230034.
(That landed just a couple of days ago though, not ~two weeks, so perhaps there is
an older regression too?)

Comment 3

[Jukka Jylänki]

Was able to build correctly on this older commit

Revision: 34983eee950dc07c7e104098ecc8cdb825ec14b3
Author: Carsten "Tomcat" Book <[e-mail]>
Date: 1/14/2016 12:58:12 PM
Message:
Merge mozilla-central to mozilla-inbound

Attempting to build from this commit did not work, but still had the problem:

Revision: 102023d0a04606700391f4b416fefc18d6f759c6
Author: Phil Ringnalda <[e-mail]>
Date: 1/23/2016 11:06:49 PM
Message:
Back out 3 changesets (bug 1214658) for b2g emulator timeouts in test_ext_contentscript_*

I mentioned "~two weeks" since I don't daily update and build, but my last sync with mozilla-central before this was roughly about two weeks ago. It could be just the issue you mentioned.

Comment 4

[Jonathan Kew [:jfkthame]]

I think you need to install "Update 1" for VS2015.

Comment 5

[Jukka Jylänki]

I can confirm that installing Update 1 fixes the build issue.

Should this bug title be renamed to "Restore support for building with Visual Studio 2015 RTM?" or "Detect Visual Studio 2015 Update 1 prerequisite in mach build"?

Comment 6

[Xidorn Quan [:xidorn] UTC+10]

Attachment: MozReview Request: Bug 1244092 - Require Update 1 to build if using Visual C++ 2015.

Review commit: https://reviewboard.mozilla.org/r/32905/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/32905/

Comment 7

[Bas Schouten (:bas.schouten)]

Can we get this reviewed and landed?

Comment 8

[Gregory Szorc [:gps]]

Will review now.

Comment 9

[Gregory Szorc [:gps]]

Comment on attachment 8713936 [details]
MozReview Request: Bug 1244092 - Require Update 1 to build if using Visual C++ 2015.

https://reviewboard.mozilla.org/r/32905/#review29883

LGTM. Thanks for adding this check.

Comment 10

[Xidorn Quan [:xidorn] UTC+10]

https://hg.mozilla.org/integration/mozilla-inbound/rev/de7e091bbcdf4ce19ccc85f66a977adeecbd30e2
Bug 1244092 - Require Update 1 to build if using Visual C++ 2015. r=gps

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/de7e091bbcdf