Display "Copy" option when tapping on the username field

RESOLVED FIXED in 2.0

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: TeoVermesan, Assigned: sleroux)

Tracking

unspecified
Other
iOS

Firefox Tracking Flags

(fxios2.0+)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Build version: 2.0(4) 

Steps to reproduce:
1. Visit http://goo.gl/vi7z6 and login with "test" and password "mozilla"
2. Remember password
3. Go to Settings > Privacy > Logins
4. Tap on a login 
5. Tap on the username field

Expected results:
-"Copy" option should be displayed

Actual results:
- Nothing happens

Note:
- "copy" option is displayed when tapping the username field
- mock-up: https://bugzilla.mozilla.org/show_bug.cgi?id=1210103#c2
(Reporter)

Updated

3 years ago
Blocks: 1210103
tracking-fxios: ? → 2.0+
Flags: needinfo?(sleroux)
(Assignee)

Updated

3 years ago
Assignee: nobody → sleroux
Status: NEW → ASSIGNED
Flags: needinfo?(sleroux)
(Assignee)

Comment 1

3 years ago
Created attachment 8715325 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1495
Attachment #8715325 - Flags: review?(etoop)
Comment on attachment 8715325 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1495

There is a bug in the code in `canPerformAction` on the menu handler, but it's not been noticed as that method doesn't get called (more info in the comment on the PR https://github.com/mozilla/firefox-ios/pull/1495#discussion-diff-51856754). Once this has been dealt with I'll r+ it.
Attachment #8715325 - Flags: feedback+
(Assignee)

Comment 3

3 years ago
master ccd133fb55c65ca216d7519cd17d3fd66b46a6f2
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0
Comment on attachment 8715325 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1495

Sorry, forgot to flip the toggle
Attachment #8715325 - Flags: review?(etoop) → review+
You need to log in before you can comment on or make changes to this bug.