1244097 - Display "Copy" option when tapping on the username field

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Teodora Vermesan (:TeoVermesan)]

Build version: 2.0(4) 

Steps to reproduce:
1. Visit http://goo.gl/vi7z6 and login with "test" and password "mozilla"
2. Remember password
3. Go to Settings > Privacy > Logins
4. Tap on a login 
5. Tap on the username field

Expected results:
-"Copy" option should be displayed

Actual results:
- Nothing happens

Note:
- "copy" option is displayed when tapping the username field
- mock-up: https://bugzilla.mozilla.org/show_bug.cgi?id=1210103#c2

Comment 1

[Stephan Leroux [:sleroux]]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1495

Comment 2

[Emily Toop (:fluffyemily)]

Comment on attachment 8715325 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1495

There is a bug in the code in `canPerformAction` on the menu handler, but it's not been noticed as that method doesn't get called (more info in the comment on the PR https://github.com/mozilla/firefox-ios/pull/1495#discussion-diff-51856754). Once this has been dealt with I'll r+ it.

Comment 3

[Stephan Leroux [:sleroux]]

master ccd133fb55c65ca216d7519cd17d3fd66b46a6f2

Comment 4

[Emily Toop (:fluffyemily)]

Comment on attachment 8715325 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1495

Sorry, forgot to flip the toggle