Closed
Bug 1244138
Opened 9 years ago
Closed 9 years ago
Hide favicon placeholders on Logins list/detail page for 2.0 release
Categories
(Firefox for iOS :: General, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: sleroux, Assigned: sleroux)
References
Details
Attachments
(1 file)
|
48 bytes,
text/x-github-pull-request
|
bnicholson
:
review+
tecgirl
:
ui-review+
|
Details | Review |
Considering how close we are to the 2.0 release and the working remaining to get favicons working properly I propose we consider the option of hiding the favicons for now until we nail down the favicon loading code in https://bugzilla.mozilla.org/show_bug.cgi?id=1233778.
|
Assignee | |
Comment 1•9 years ago
|
||
This patch hides the default favicons for the logins until we can resolve issues with loading favicons for loading: https://github.com/mozilla/firefox-ios/pull/1445. There is some risk in the favicon patch that I'm working with Richard through and I don't feel confident in landing it for 2.0.
Attachment #8713733 -
Flags: ui-review?(randersen)
Attachment #8713733 -
Flags: review?(bnicholson)
|
||
Updated•9 years ago
|
Attachment #8713733 -
Flags: review?(bnicholson) → review+
|
||
Updated•9 years ago
|
Attachment #8713733 -
Flags: ui-review?(randersen) → ui-review+
|
|
Assignee | |
Comment 2•9 years ago
|
||
master 965d6fb9cf4c140ac99bd69063b37dbc3944d1c1
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•