1244245 - Enable eslint "curly" rule for PSM

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[:Cykesiopka]

The rule helps enforce things like braces around conditional bodies.

Comment 1

[:Cykesiopka]

Attachment: MozReview Request: Bug 1244245 - Enable eslint "curly" rule for PSM. r=keeler

Also includes minor cleanup.

Review commit: https://reviewboard.mozilla.org/r/34717/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/34717/

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

As a heads-up, I probably won't get to this until Tuesday.

Comment 3

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Comment on attachment 8718714 [details]
MozReview Request: Bug 1244245 - Enable eslint "curly" rule for PSM. r=keeler

https://reviewboard.mozilla.org/r/34717/#review31809

Great - thanks!

::: security/manager/pki/resources/content/viewCertDetails.js:162
(Diff revision 1)
>          return this;

nit: indent two fewer spaces, I think?

::: security/manager/ssl/tests/mochitest/mixedcontent/mixedContentTest.js
(Diff revision 1)
> -        SimpleTest.todo(false, event.data);

Are there no more todos in this test?

Comment 4

[:Cykesiopka]

Comment on attachment 8718714 [details]
MozReview Request: Bug 1244245 - Enable eslint "curly" rule for PSM. r=keeler

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/34717/diff/1-2/

Comment 5

[:Cykesiopka]

https://reviewboard.mozilla.org/r/34717/#review31809

Thanks for the review!

> Are there no more todos in this test?

No, there are no more todos (confirmed via mochitest runs and a DXR search).

Comment 6

[:Cykesiopka]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c34721b5f572

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/62cb1e729937

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/62cb1e729937