Closed Bug 1244245 Opened 6 years ago Closed 6 years ago

Enable eslint "curly" rule for PSM

Categories

(Core :: Security: PSM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: Cykesiopka, Assigned: Cykesiopka)

References

Details

Attachments

(1 file)

The rule helps enforce things like braces around conditional bodies.
As a heads-up, I probably won't get to this until Tuesday.
Comment on attachment 8718714 [details]
MozReview Request: Bug 1244245 - Enable eslint "curly" rule for PSM. r=keeler

https://reviewboard.mozilla.org/r/34717/#review31809

Great - thanks!

::: security/manager/pki/resources/content/viewCertDetails.js:162
(Diff revision 1)
>          return this;

nit: indent two fewer spaces, I think?

::: security/manager/ssl/tests/mochitest/mixedcontent/mixedContentTest.js
(Diff revision 1)
> -        SimpleTest.todo(false, event.data);

Are there no more todos in this test?
Attachment #8718714 - Flags: review?(dkeeler) → review+
Comment on attachment 8718714 [details]
MozReview Request: Bug 1244245 - Enable eslint "curly" rule for PSM. r=keeler

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/34717/diff/1-2/
Attachment #8718714 - Attachment description: MozReview Request: Bug 1244245 - Enable eslint "curly" rule for PSM. → MozReview Request: Bug 1244245 - Enable eslint "curly" rule for PSM. r=keeler
https://reviewboard.mozilla.org/r/34717/#review31809

Thanks for the review!

> Are there no more todos in this test?

No, there are no more todos (confirmed via mochitest runs and a DXR search).
https://hg.mozilla.org/mozilla-central/rev/62cb1e729937
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.