1244292 - crash in java.util.concurrent.TimeoutException: android.media.MediaCodec.finalize() timed out after 10 seconds at android.media.MediaCodec.native_finalize(Native Method)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Audio/Video, defect)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

This bug was filed from the Socorro interface and is 
report bp-28981f3c-f3da-4513-85f3-6061a2160129.
=============================================================

Most of these seem to be on rockchip boards, though not all of them.

Comment 1

[Eugen Sawin [:esawin]]

This would be triggered if the process is sent to sleep during a GC sweep.

The increased report frequency of this could indicate that we are forcing GC due to high memory usage (maybe related to bug 1216460) combined with the fact that users specifically choose Fennec to play media in background as that use case if often restricted by other apps.

It could also indicate that we're not setting wake locks properly, but that doesn't seem to be the case (sadly none of the crash comments does mention the site or media used).

I will try to reproduce this on a low-end device.

Comment 2

[Eugen Sawin [:esawin]]

Some of the stack traces show a high amount of active decoders during the crash. This could indicate another issue with bugged platform support for multiple decoders (see bug 1214710).

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

This is now the #1 crash on 45b3, so let's definitely get this figured out.

Comment 4

[Eugen Sawin [:esawin]]

This is reproducing on Samsung GT-I9300 when playing many videos (MP4/H.264, ~4-8) simultaneously.
Restricting the number of allowed decoders would prevent the failures, but might break some use cases.

Comment 5

[Eugen Sawin [:esawin]]

Attachment: 0001-Bug-1244292-1.1-Release-decoder-on-init-failure.-r-s.patch

This issue is different to bug 1214710, in this case we fail during decoder initialization (ResetInputBuffers), in which case we don't shutdown the decoder properly.

We can avoid the crashing by shutting down the decoder on init failure (this patch), but media playback would still fail and I don't see anything we can do on our side to help with that.

We would still need to limit the number of active decoders in this case, too.

Comment 6

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8717544 [details] [diff] [review]
0001-Bug-1244292-1.1-Release-decoder-on-init-failure.-r-s.patch

Review of attachment 8717544 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/platforms/android/AndroidDecoderModule.cpp
@@ +759,4 @@
>  
> +  if (mDecoder) {
> +    mDecoder->Stop();
> +    mDecoder->Release();

probably should set mDecoder to nullptr here, right?

Comment 7

[Eugen Sawin [:esawin]]

Attachment: 0001-Bug-1244292-1.2-Release-decoder-on-init-failure.-r-s.patch

Addressed comment.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9b3787b43a59

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9b3787b43a59

Comment 10

[Eugen Sawin [:esawin]]

Comment on attachment 8717587 [details] [diff] [review]
0001-Bug-1244292-1.2-Release-decoder-on-init-failure.-r-s.patch

Approval Request Comment
[Feature/regressing bug #]: media playback on specific (popular) devices
[User impact if declined]: crash on failed playback initialization (#2 crasher on beta)
[Describe test coverage new/current, TreeHerder]: local testing, on Nightly for a few days
[Risks and why]: low, minimal code change, fixes shutdown in case of failed decoder initialization 
[String/UUID change made/needed]: none

Comment 11

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8717587 [details] [diff] [review]
0001-Bug-1244292-1.2-Release-decoder-on-init-failure.-r-s.patch

Fix for android crash, please uplift to aurora and beta.

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f68ebea8edd8

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f68ebea8edd8

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/339b62e92a29