Don't upload telemetry if user opts out

RESOLVED FIXED in Firefox 45

Status

()

Firefox for Android
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mcomella, Assigned: mcomella)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 47
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox45 fixed, firefox46 fixed, firefox47 fixed, fennec45+)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Looks like I forgot to include this functionality in the initial implementation.
Summary: Don't upload telemetry if user ops out → Don't upload telemetry if user opts out
Created attachment 8713876 [details]
MozReview Request: Bug 1244293 - Don't upload telemetry if user opts out. r=mfinkle

I'm slightly concerned we're providing too much configuration information in
the debugging statements.

Review commit: https://reviewboard.mozilla.org/r/32841/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/32841/
Attachment #8713876 - Flags: review?(mark.finkle)
Attachment #8713876 - Flags: review?(mark.finkle) → review+
Comment on attachment 8713876 [details]
MozReview Request: Bug 1244293 - Don't upload telemetry if user opts out. r=mfinkle

https://reviewboard.mozilla.org/r/32841/#review29741

::: mobile/android/services/src/main/java/org/mozilla/gecko/background/BackgroundService.java:44
(Diff revision 1)
> -  protected boolean backgroundDataIsEnabled() {
> +  protected static boolean backgroundDataIsEnabled(final Context context) {

Looks like backgroundDataIsEnabled has never been used anywhere else. How do we know this code works as intended?
https://reviewboard.mozilla.org/r/32841/#review29741

> Looks like backgroundDataIsEnabled has never been used anywhere else. How do we know this code works as intended?

It was used by the `HealthReportUploadService` in a simila manner to this patch.

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6c9e43e567ef
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
NI self – we should verify in tomorrow's Nightly that this does not affect the numbers we're receiving in an unexpected way.
Flags: needinfo?(michael.l.comella)
Let's land with the initial core ping implementation (bug 1205835).
tracking-fennec: --- → 45+
(In reply to Michael Comella (:mcomella) from comment #6)
> NI self – we should verify in tomorrow's Nightly that this does not affect
> the numbers we're receiving in an unexpected way.

This should be in the 2/5 build, which I can see on the telemetry s3 server at the following url:
 <s3-server>/telemetry-2/20160205/telemetry/1/core/Fennec/nightly/47.0a1/

Using `ls | wc -l`, there are 89% of pings from 2/5 builds on 2/5 as there were for 2/3 for builds from 2/3. The day's not over yet so this drop seems reasonable but it's worth noting that our Nightly numbers of users on a build built that day may not be statistically significant enough to really do this analysis. That being said, we're still getting pings and I'm satisfied. :)
Flags: needinfo?(michael.l.comella)
Comment on attachment 8713876 [details]
MozReview Request: Bug 1244293 - Don't upload telemetry if user opts out. r=mfinkle

This must be uplifted with bug 1205835.

Approval Request Comment
[Feature/regressing bug #]: Landing of bug 1205835
[User impact if declined]: Users can't opt out of telemetry, which probably breaks our privacy policy or something

[Describe test coverage new/current, TreeHerder]: Tested locally, verified on Nightly that uploads are not broken (i.e. data is still coming in)
[Risks and why]: Low – we move some existing checks around and add a check for whether or not the preference is enabled.

[String/UUID change made/needed]: None
Attachment #8713876 - Flags: approval-mozilla-beta?
Attachment #8713876 - Flags: approval-mozilla-aurora?
This (and probably a bunch of the related uplift requests) needs to be rebased to work around the lack of bug 1107811 on the release branches.
Flags: needinfo?(michael.l.comella)

Comment 11

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/92e846782a65
status-firefox46: --- → fixed

Comment 12

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/4ae5b1d83228
status-firefox45: --- → fixed

Updated

2 years ago
Flags: needinfo?(michael.l.comella)
Comment on attachment 8713876 [details]
MozReview Request: Bug 1244293 - Don't upload telemetry if user opts out. r=mfinkle

michael had my approval. Updating the uplift flags for posterity.
Should be in 45 beta 4
Attachment #8713876 - Flags: approval-mozilla-beta?
Attachment #8713876 - Flags: approval-mozilla-beta+
Attachment #8713876 - Flags: approval-mozilla-aurora?
Attachment #8713876 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.