crash in nr_ice_ctx_destroy_cb

RESOLVED FIXED in Firefox 47

Status

()

Core
WebRTC: Networking
P3
normal
Rank:
30
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: bwc, Assigned: bwc)

Tracking

({crash, csectype-nullptr})

Trunk
mozilla47
Unspecified
Android
crash, csectype-nullptr
Points:
---

Firefox Tracking Flags

(firefox47 fixed)

Details

(crash signature)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
This bug was filed from the Socorro interface and is 
report bp-b4ca230c-aea7-4154-b486-6cbbb2160129.
=============================================================


This appears to happen because STAILQ_INIT is not called until the end of nr_ice_ctx_create, which means an ABORT before then leaves something that nr_ice_ctx_destroy_cb cannot operate on safely. Need to analyze more closely.
Group: core-security → media-core-security

Updated

2 years ago
backlog: --- → webrtc/webaudio+
Rank: 10
Priority: -- → P1
-> bwc for analysis
Assignee: nobody → docfaraday
(Assignee)

Comment 2

2 years ago
Ok, this looks like a hard-to-trigger null-pointer crash. Can someone un-mark?
(Assignee)

Updated

2 years ago
Severity: critical → normal
Rank: 10 → 30
Priority: P1 → P3

Updated

2 years ago
Group: media-core-security
Keywords: csectype-nullptr
(Assignee)

Comment 3

2 years ago
Created attachment 8714816 [details]
MozReview Request: Bug 1244338: Don't try to clean up |ctx| if null. r?drno

Review commit: https://reviewboard.mozilla.org/r/33245/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33245/
Attachment #8714816 - Flags: review?(drno)
Comment on attachment 8714816 [details]
MozReview Request: Bug 1244338: Don't try to clean up |ctx| if null. r?drno

https://reviewboard.mozilla.org/r/33245/#review30023

LGTM
Attachment #8714816 - Flags: review?(drno) → review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 5

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/3b5fba74776c
Keywords: checkin-needed

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3b5fba74776c
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox47: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.