1244410 - Intermittent e10s test_DrainOnMissingData_mp4.html | Video has correct currentTime. - got 0.801677, expected 0.801666

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P5)

Description

[Phil Ringnalda (:philor)]

https://treeherder.mozilla.org/logviewer.html#?job_id=20755246&repo=mozilla-inbound

Comment 1

[Intermittent Failures Robot]

7 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* fx-team: 5
* mozilla-inbound: 2

Platform breakdown:
* linux64: 4
* linux32: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1244410&startday=2016-02-01&endday=2016-02-07&tree=all

Comment 2

[Intermittent Failures Robot]

7 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* fx-team: 4
* mozilla-inbound: 3

Platform breakdown:
* linux64: 5
* linux32: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1244410&startday=2016-02-08&endday=2016-02-14&tree=all

Comment 3

[Jean-Yves Avenard [:jya]]

Attachment: MozReview Request: Bug 1244410: [ffmpeg] Ensure the last drained frame has the proper duration set. r?gerald

FFmpeg's AVFrame pkt_dts doesn't contain the dts of the frame used to decode the frame; but of the frame "that triggered returning this frame.". The last frame was returned when draining which is done by feeding the decoder with dummy frames ; all having a dts of 0.

Additionally, rename DurationMap argument name from aDts to aKey.

Review commit: https://reviewboard.mozilla.org/r/51025/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/51025/

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8749534 [details]
MozReview Request: Bug 1244410: [ffmpeg] Ensure the last drained frame has the proper duration set. r?gerald

https://reviewboard.mozilla.org/r/51025/#review47685

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7d9879db28af

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7d9879db28af

Comment 7

[Jean-Yves Avenard [:jya]]

The one showing in https://treeherder.mozilla.org/logviewer.html#?job_id=3916007&repo=mozilla-central

is actually the same as bug 1272964; Skip to next keyframe actually jumped over a gap, causing currentTime to be at 9s rather than 0.8s