Closed Bug 1244412 Opened 4 years ago Closed 4 years ago

Intermittent bug-1232386.js | Assertion failure: zone->runtimeFromAnyThread()->gc.nursery.isEmpty()

Categories

(Core :: JavaScript: GC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox47 --- fixed
firefox48 --- fixed

People

(Reporter: philor, Assigned: jonco)

References

Details

(Keywords: intermittent-failure)

Attachments

(2 files)

The problem is that Zone::discardJitCode uses a ZoneCellIterUnderGC but can be called from AutoClearTypeInferenceStateOnOOM when not under a GC.

I think the easiest fix is to make ZoneCellIter work correctly whether called under a GC or not.
Assignee: nobody → jcoppeard
Attachment #8730668 - Flags: review?(terrence)
I'm in two minds about this because I like the documentation aspect of calling the 'UnderGC' version of the iterator, but there doesn't seem to be that much point in keeping it if ZoneCellIter works for both cases.
Attachment #8730669 - Flags: review?(terrence)
Attachment #8730669 - Flags: review?(terrence) → review+
Attachment #8730668 - Flags: review?(terrence) → review+
Duplicate of this bug: 1240736
47 is marked as affected. Should this be uplifted?
Flags: needinfo?(jcoppeard)
Comment on attachment 8730668 [details] [diff] [review]
bug1244412-zone-cell-iter-fix

Approval Request Comment
[Feature/regressing bug #]: At the latest bug 1072564 but maybe earlier.
[User impact if declined]: Possible crash on OOM.
[Describe test coverage new/current, TreeHerder]: On m-c for over a month.
[Risks and why]: Low.
[String/UUID change made/needed]: None.
Flags: needinfo?(jcoppeard)
Attachment #8730668 - Flags: approval-mozilla-aurora?
Comment on attachment 8730668 [details] [diff] [review]
bug1244412-zone-cell-iter-fix

OOM Crash fix, has been on Nightly48 for over a month, Beta47+
Attachment #8730668 - Flags: approval-mozilla-aurora? → approval-mozilla-beta+
Depends on: 1264300
You need to log in before you can comment on or make changes to this bug.