1244438 - Media.autoplay.enabled=false does not work if a script loads a next page

Status: RESOLVED WONTFIX

(Core :: Audio/Video: Playback, defect, P3)

Description

[John Doe]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/43.2357.124 Safari/537.36

Steps to reproduce:

1) set media.autoplay.enabled to false
2) go to youtube, find some video; it does not autoplay as per settings (correct)
3) click on the video to make it play
4) leave it playing


Actual results:

The video finished, some script loaded a new/next page and a video on that page autoplayed without any human interaction whatsoever.


Expected results:

I would expect the video on the next page not to autoplay, more so given the fact the page itself loaded automatically without human interaction.

Comment 1

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Mass change P2 -> P3

Comment 2

[Farmer Tseng[:fatseng](inactive)]

I would like to set mHasUserInteraction as false in HTMLMediaElement::Ended() while mDecoder->IsEndedOrShutdown() return true.
It could prevent to autoplay on the next page.
Any suggestion?

Comment 3

[Farmer Tseng[:fatseng](inactive)]

Attachment: 0001-Bug-1244438-set-mHasUserInteraction-as-false-while-p.patch

I set mHasUserInteraction as false while HTMLMediaElement::PlaybackEnded is called.
It could prevent autoplay next page.

Comment 4

[Farmer Tseng[:fatseng](inactive)]

Here is try server result.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6292a41d9dce

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8773679 [details] [diff] [review]
0001-Bug-1244438-set-mHasUserInteraction-as-false-while-p.patch

Review of attachment 8773679 [details] [diff] [review]:
-----------------------------------------------------------------

Please use mozreview for review requests.

YouTube provide a slider at the top right of "up next" list to disable playing the next video in the "up next" list.

Once a video element is approved to play, I don't want to revoke approval.

Comment 6

[John Doe]

Yeah, that is nice of youtube, but the whole point of disabling autoplay is that, ideally, I disable it once in the browser, as opposed to disabling it per website and even per visit, and videos play when I click them, only then, and never ever start playing on their own.

I do not insist on media.autoplay.enabled though. There could be new option for it, like media.autoplay.reallyreallyreally.disable.on_youtube_too=reallysure. Then you could keep your blatantly broken media.autoplay.enabled as it is, as you apparently cherish it a lot, and the rest of us would not be nagged by autoplaying videos. Sounds fair, no?