1244439 - Build fails due to missing include paths

Status: RESOLVED DUPLICATE of bug 1242719

(Core :: Audio/Video: MediaStreamGraph, defect)

Description

[Martin Husemann]

Attachment: add the missing include directives

In my local builds included paths are missing and I get failures like:

c++ -o Unified_cpp_dom_media2.o -c -I/ssd/pkgobj/wip/firefox-hg/work/build/dist/stl_wrappers -I/ssd/pkgobj/wip/firefox-
hg/work/build/dist/system_wrappers -include /ssd/pkgobj/wip/firefox-hg/work/mozilla/config/gcc_hidden.h -DNDEBUG=1 -DTR
IMMED=1 -DMOZILLA_INTERNAL_API -DWEBRTC_POSIX -DOS_POSIX=1 -DOS_NETBSD=1 -DOS_BSD=1 -DSTATIC_EXPORTABLE_JS_API -DMOZILL
A_INTERNAL_API -DIMPL_LIBXUL -I/ssd/pkgobj/wip/firefox-hg/work/mozilla/dom/media -I/ssd/pkgobj/wip/firefox-hg/work/buil
d/dom/media -I/ssd/pkgobj/wip/firefox-hg/work/mozilla/caps -I/ssd/pkgobj/wip/firefox-hg/work/mozilla/dom/base -I/ssd/pk
gobj/wip/firefox-hg/work/mozilla/dom/camera -I/ssd/pkgobj/wip/firefox-hg/work/mozilla/layout/generic -I/ssd/pkgobj/wip/
firefox-hg/work/mozilla/layout/xul -I/ssd/pkgobj/wip/firefox-hg/work/mozilla/netwerk/base -I/ssd/pkgobj/wip/firefox-hg/
work/build/ipc/ipdl/_ipdlheaders -I/ssd/pkgobj/wip/firefox-hg/work/mozilla/ipc/chromium/src -I/ssd/pkgobj/wip/firefox-h
g/work/mozilla/ipc/glue -I/ssd/pkgobj/wip/firefox-hg/work/build/dist/include  -I/ssd/pkgobj/wip/firefox-hg/work/build/d
ist/include/nspr -I/ssd/pkgobj/wip/firefox-hg/work/build/dist/include/nss    -I/usr/X11R7/include/pixman-1   -fPIC -DPI
C  -DMOZILLA_CLIENT -include /ssd/pkgobj/wip/firefox-hg/work/build/mozilla-config.h -MD -MP -MF .deps/Unified_cpp_dom_m
edia2.o.pp -I/usr/pkg/include -I/usr/include -I/usr/X11R7/include -I/usr/X11R7/include/libdrm -I/usr/X11R7/include/free
type2 -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wtype-limits -Wunreachable-code -Wc
ast-align -Wno-invalid-offsetof -O2 -pipe -I/usr/pkg/include -I/usr/include -I/usr/X11R7/include -I/usr/X11R7/include/l
ibdrm -I/usr/X11R7/include/freetype2 -fno-exceptions -fno-strict-aliasing -Dunix -fno-rtti -fno-exceptions -fno-math-er
rno -std=gnu++0x -pthread -pipe  -g -O2 -fomit-frame-pointer  -Wno-error=attributes   /ssd/pkgobj/wip/firefox-hg/work/b
uild/dom/media/Unified_cpp_dom_media2.cpp
In file included from /ssd/pkgobj/wip/firefox-hg/work/build/dom/media/Unified_cpp_dom_media2.cpp:29:0:
/ssd/pkgobj/wip/firefox-hg/work/mozilla/dom/media/MediaStreamGraph.cpp:34:39: fatal error: mtransport/runnable_utils.h: No such file or directory
 #include "mtransport/runnable_utils.h"
                                       ^
compilation terminated.

The same happens for dom/network/UDPSocketParent.cpp

I am not sure which option triggers this (i.e. why this does not cause more global fallout), but I guess the changes are fine anyway?

Comment 1

[Jan Beich]

(In reply to Martin Husemann from comment #0)
> -I/ssd/pkgobj/wip/firefox-hg/work/build/dist/include
[...]
> fatal error: mtransport/runnable_utils.h: No such file or directory
>  #include "mtransport/runnable_utils.h"
>                                        ^

According to |cc -E| on my box -I$(DIST)/include added by default should be enough. Maybe it's not populated in your case.

  # 19 "/path/to/moz_objdir/dist/include/mtransport/runnable_utils.h"

Can you try |./mach build| in case |gmake -f client.mk| is no longer enough?

Comment 2

[Faizan Ahmad'"]

Great finding'">,

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

This is likely the result of building with --disable-webrtc.  That include hack will work, though it's very much a hack.  A better hack would make that hack conditional on webrtc not being enabled (if CONFIG['MOZ_WEBRTC']:)

Comment 4

[Martin Husemann]

Indeed I am using --disable-webrtc