1244519 - fairphone2 doesn't flash to Phone after successful build. Unsupported device "FP2", can't flash

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Hardware, defect)

Description

[Novski]

Attachment: Screenshot from 2016-01-30 17:08:15.png

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:44.0) Gecko/20100101 Firefox/44.0
Build ID: 20160126223146

Steps to reproduce:

I followed this:
01. https://developer.mozilla.org/en-US/docs/Mozilla/Firefox_OS/Preparing_for_your_first_B2G_build and:
02. terminal code: sudo bash
03. terminal code: apt-get install phablet-tools android-tools-adb android-tools-fastboot
04. terminal code: mkdir ~/firefox_os
05. terminal code: cd firefox_os
06. terminal code: apt-get install git
07. terminal code: git clone git://github.com/mozilla-b2g/B2G.git && cd B2G
08. terminal code: ./config.sh
09. terminal code: ./config.sh fairphone2 - and off it goes for 2-3h
10. connected phone
11. de-checked all connection boxes and activated debug mode by pressing the last menu item 7 times. then a new menu called developer options apears. 
12. terminal code: adb devices - there must be more then just this: "List of devices attached" at least a number in front of Device.
13. terminal code: mkdir ~/fairphone_os
14. terminal code: cd fairphone_os
15. terminal code: adb pull /system ~/fairphone_os/system - that makes a backup of your momentary phone os
16. terminal code: adb pull /data ~/fairphone_os/data - maybe there is nothing and it will do nothng. Thats ok.
17. terminal code: adb pull /vendor ~/fairphone_os/vendor - may give a error. Check if you find a folder called vendor in the Fairphone_os/system folder.
18. https://developer.mozilla.org/en-US/Firefox_OS/Building
19. terminal code: apt-get install git
20. terminal code: git pull
21. terminal code: ./repo sync -d
22. terminal code: -/repo sync
23. terminal code: cd B2G
24. terminal code: ./build.sh -j8
25. https://developer.mozilla.org/en-US/docs/Mozilla/Firefox_OS/Installing_on_a_mobile_device
26. terminal code: adb devices / -> List of devices attached / 234fa0 device
27. terminal code: ./flash.sh

28. terminal output: Unsupported device "FP2", can't flash


Actual results:

28. terminal output: Unsupported device "FP2", can't flash

then i also tried to set phone in fastboot mode and terminal code: fastboot devices gave out a devicename so i tried ./flash again but same result.


Expected results:

flashing the phone...

Comment 1

[erotavlas]

I confirm this bug. This is the output of flash.sh script under Ubuntu 14.04 LTS 64 bit.

+ . load-config.sh
++ [[ ! -n '' ]]
++++ dirname load-config.sh
+++ cd .
+++ pwd
++ B2G_DIR=/home/tore/Desktop/Firefox_OS/B2G
++ . /home/tore/Desktop/Firefox_OS/B2G/.config
+++ MAKE_FLAGS=-j6
+++ GECKO_OBJDIR=/home/tore/Desktop/Firefox_OS/B2G/objdir-gecko
+++ DEVICE_NAME=fairphone2
+++ PRODUCT_NAME=FP2
++ '[' 0 -ne 0 ']'
++ '[' -f /home/tore/Desktop/Firefox_OS/B2G/.userconfig ']'
++ '[' -z ']'
++ GECKO_PATH=/home/tore/Desktop/Firefox_OS/B2G/gecko
++ VARIANT=eng
++ PRODUCT_NAME=FP2
++ DEVICE=FP2
++ LUNCH=FP2-eng
++ DEVICE_DIR='device/*/FP2'
+ test -f 'device/*/FP2/flash.sh'
+ ADB=adb
+ FASTBOOT=fastboot
+ HEIMDALL=heimdall
+ VARIANT=eng
+ FULLFLASH=false
++ which adb
+ '[' '!' -f /usr/bin/adb ']'
++ which fastboot
+ '[' '!' -f '' ']'
++ uname -s
++ tr '[[:upper:]]' '[[:lower:]]'
+ FASTBOOT=out/host/linux-x86/bin/fastboot
+ '[' 0 -gt 0 ']'
+ case "$PROJECT" in
+ case "$DEVICE" in
++ type -t flash_FP2
+ [[ '' = function ]]
+ echo Unsupported device '"FP2",' 'can'\''t' flash
Unsupported device "FP2", can't flash
+ exit -1

Comment 2

[:gerard-majax]

It's just we forgot to add it to the flash script

Comment 3

[:gerard-majax]

Attachment: B2G PR

Juan, there was no pending PR for this so I did it. Can you verify on your device?

Comment 4

[:gerard-majax]

Novski, thanks for the report. Since you are willing to produce images, I would suggest to also give extensive reading of the docs about updates :)

https://developer.mozilla.org/en-US/Firefox_OS/Building_and_installing_Firefox_OS/Firefox_OS_update_packages

Comment 5

[Novski]

seams like thats not all to me. 
I changed this line manualy: 
"panda"|"maguro"|"crespo"|"crespo4g"|"mako"|"hammerhead"|"flo"|"shamu")
to:
"panda"|"maguro"|"crespo"|"crespo4g"|"mako"|"hammerhead"|"flo"|"shamu"|"fairphone2")
as i seen in the link above to github.

But if i then save and ./flash.sh
it still shows : Unsupported device "FP2", can't flash

and if i try direct over: fastboot -p FP2 flashall
it shows this: error: could not load android-info.txt: No such file or directory
even i see the file in the directory: out/target/product/FP2/
it has only one line: board=FP2

Regards, Novski

Comment 6

[:gerard-majax]

PR should be good now, I mixed DEVICE and the way we handle them in the scripts.

Comment 7

[Juan Gomez [:_AtilA_] (CET/CEST)]

Thanks for the report Novski!
Alex, yeah, that is what was missing.
Merged!
https://github.com/mozilla-b2g/B2G/commit/f7276c96cf8f8646069fc93b91428e08b38c074a

Comment 8

[erotavlas]

(In reply to Alexandre LISSY :gerard-majax from comment #6)
> PR should be good now, I mixed DEVICE and the way we handle them in the
> scripts.

Yes, I found the same mistake on code. The device name have to be FP2 not fairphone2
PRODUCT_NAME=FP2
DEVICE=FP2
Now it works!!!

Comment 9

[Juan Gomez [:_AtilA_] (CET/CEST)]

Comment on attachment 8714068 [details]
Screenshot from 2016-01-30 17:08:15.png

Ups! forgot to set the +! :)

Comment 10

[Novski]

Hi 
That did work! now i was able to flash the device...
But uf corse there are more problems now. 
I will open a single bug for every problem i find.
But does any of the developers have a device to test or do you have to relay on my experiences?
Regards, Novski

Comment 11

[:gerard-majax]

I don't have one, but Juan has a device with him. What are the other issues you ran into? Mostly everything works as far as we could test on Juan's build yesterday.

Comment 12

[Novski]

uh. so maybe mine is broken. I indeed had a blank phone because i tried to flash manualy and run in to a problem. It was totaly dead. not even the recovery booted. so it may be that i have to reflash the initial os befor i load firefox os...
I had no SIM or Cellular connection and a errormessage in the notification center, also i had no WIFI and the clock was reset every time i rebooted... :-)
I will try to compile and flash a FPOSOS and see how much works with that, then i get back.
Regards, Novski

Comment 13

[Novski]

hi.
I now have problems to build. The build failed now several times and i can't say what i did else than yesterday... I was able to build until now... 
May somebody sync and try to build as well? just to be shure its not in the repo a problem...
Thanks, Novski

Comment 14

[erotavlas]

(In reply to Novski from comment #13)
> hi.
> I now have problems to build. The build failed now several times and i can't
> say what i did else than yesterday... I was able to build until now... 
> May somebody sync and try to build as well? just to be shure its not in the
> repo a problem...
> Thanks, Novski
Try to start from scratch by typing "rm -rf out" from B2G folder in order to wipe out the previous build.

Comment 15

[:gerard-majax]

(In reply to Novski from comment #13)
> hi.
> I now have problems to build. The build failed now several times and i can't
> say what i did else than yesterday... I was able to build until now... 
> May somebody sync and try to build as well? just to be shure its not in the
> repo a problem...
> Thanks, Novski

We cannot do anything without any complete log of the failure ran with |./build.sh -j1|

Comment 16

[erotavlas]

Attachment: Building bug

Comment 17

[erotavlas]

(In reply to Alexandre LISSY :gerard-majax from comment #15)
> (In reply to Novski from comment #13)
> > hi.
> > I now have problems to build. The build failed now several times and i can't
> > say what i did else than yesterday... I was able to build until now... 
> > May somebody sync and try to build as well? just to be shure its not in the
> > repo a problem...
> > Thanks, Novski
> 
> We cannot do anything without any complete log of the failure ran with
> |./build.sh -j1|

I confirm that there is bug error with latest code from github. The output code is generated by ./build.sh -j1.

Comment 18

[:gerard-majax]

(In reply to erotavlas from comment #16)
> Created attachment 8714744 [details]
> Building bug

That is not a complete build log, I don't even see the root cause. Please file a new bug.

Comment 19

[:gerard-majax]

Filed bug 1245058