1244528 - Default to DBD::SQLite for new installs for "out of the box" working bugzilla experience

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, enhancement)

Description

[Dylan Hardison [:dylan] (he/him)]

I would like to be able to checkout bugzilla, run cpanm && checksetup.pl && plackup and have it work. For that another thing that is needed is a working database -- we can do this with SQLite. It's not great for production but drastically lowers the bar to contributing to Bugzilla.

Comment 1

[Dylan Hardison [:dylan] (he/him)]

Attachment: 1244528_1.patch

Comment 2

[Frédéric Buclin]

Comment on attachment 8716678 [details] [diff] [review]
1244528_1.patch

>     {
>         name    => 'db_name',
>-        default => 'bugs',
>+        default => 'data/bugzilla.sqlite3',
>     },

Why do you edit db_name? By default, the sqlite DB will be installed in data/db/, which is fine. I see no reason to put it in data/ itself. This would also prevent trouble with other DBs (such as MySQL or Pg), because your change makes us think that you have to specify the full path to the DB, which is incorrect. So please revert this change.


>     {
>         name    => 'db_user',
>-        default => 'bugs',
>+        default => '',
>     },

This change is also useless. It's totally fine to have db_user set, and is a good default. Please revert this change too.

Comment 3

[Dylan Hardison [:dylan] (he/him)]

Attachment: 1244528_2.patch

I am very uncomfortable with the level of magic we're doing in our subclass of DBD::SQLite but I'll reserve that battle for another day.

Comment 4

[David Lawrence [:dkl]]

Comment on attachment 8716803 [details] [diff] [review]
1244528_2.patch

Review of attachment 8716803 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl

Comment 5

[Dylan Hardison [:dylan] (he/him)]

To ssh://[e-mail]/bugzilla/bugzilla.git
   9faa0dc..6bd668c  master -> master