124454 - Page info displays media/images at the wrong size.

Status: RESOLVED FIXED

(SeaMonkey :: Page Info, defect, P3)

Description

[Jeremy M. Dolan]

Page info displays images of type icon at the wrong size.

For example, go to my page, http://turbogeek.org , and look under media in page
info. First image is the icon. It's slightly smushed, though. 15x15 instead of
16x16 perhaps.

Also, the dimentions are listed as unknown. It's a normal PNG. Shows right if
you access it directly.

Comment 1

[sairuh (rarely reading bugmail)]

over to page info

Comment 2

[Uwe Schröder]

This happens with all images. Displayed image size is original size minus
border-width, i.e. a 16x16 icon is shown as 12x12 plus 2px border on each side.

That means, of course, that images smaller than 4px are not shown at all.

Comment 3

[Daniel Brooks [:db48x]]

hrm. if this is the case than it's a regression of some kind, or at the very
least it's related to the old bug where it listed the dimensions minus the
border width. Do the image dimensions print out correctly?

Comment 4

[Neil Marshall]

It doesn't print out the dimensions on a favicon.

Comment 5

[Uwe Schröder]

As far as I can see, image dimensions print out correctly for normal images.
It's just the image display that ist wrong.

Comment 6

[Daniel Brooks [:db48x]]

the problem is that the DOM doesn't expose the dimensions because it's not
really an image tag, it's a link.

Comment 7

[Jeremy M. Dolan]

Not just icons. All graphics are being scaled from x*y to (x-1)*(y-1). Makes
certain images look awful. All five images on my page (turbogeek.org) are being
scaled down by 1px it looks like. Screwed the w3 icons up badly.

Comment 8

[Daniel Brooks [:db48x]]

that's a different bug. if you take the border off of the image, the scaling 
effect goes away. it's really weird.

Comment 9

[Daniel Brooks [:db48x]]

Attachment: removes border as workaround

also makes the preview area bigger by making the image list a bit smaller. it
was too big before.

Comment 10

[Jeremy M. Dolan]

+  margin: 1em;x

er.. "x"? typo, or some CSS thing I don't know about. Anyway, fix here would be
super nice. Keep up the good work.

Comment 11

[Daniel Brooks [:db48x]]

Attachment: oopsies

Comment 12

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 95157 [details] [diff] [review]
oopsies

sr=bzbarsky

Comment 13

[Jeremy M. Dolan]

New patch looks good. Works for me, and, though I have no review powers, since
you're the component owner, and I'm the reporter... review process be damned! r=jmd

Comment 14

[Alec Flett]

Comment on attachment 95157 [details] [diff] [review]
oopsies

r=alecf

Comment 15

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in