Closed Bug 1244582 Opened 4 years ago Closed 4 years ago

[e10s] Ctrl+mouse wheel to change zoom level doesn't work if chrome input fields are focused (crashes tab)

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: arni2033, Assigned: khuey)

References

()

Details

(Keywords: crash, regression, reproducible)

Attachments

(1 file)

>>>   My Info:   Win7_64, Nightly 46, 32bit, ID 20160129030206
STR:
1. Open http://example.org/
2. Press Ctrl+F to open and focus Findbar
3. Place mouse pointer over the page content, hold Ctrl and rotate mouse wheel up and down

AR:  Tab crashes
ER:  Tab should change zoom level

I think that crash is a recent regression. It doesn't happen on Dev.Edition 45
I was going to file this as simply Ctrl+Wheel not working, but now it also causes the crash...
Sorry, info in comment 0 is incorrect. I'm using:  Win7_64, Nightly 46, 32bit, ID 20160131030347
This is regression between 47.0a1 (2016-01-30) and 47.0a1 (2016-01-31).
Mozregression GUI can't handle this  =(
Could you post a link to a crash report from about:crashes? Seeing the crash stack might allow us to identify the problem faster than a regression window.
Flags: needinfo?(arni2033)
bp-a6532bae-c496-4bd2-aad3-70b262160201
Flags: needinfo?(arni2033)
Thanks! This looks likely to be a regression from bug 1241764.
Blocks: 1241764
Component: Panning and Zooming → DOM
Flags: needinfo?(khuey)
Yeah, looks like I effectively removed a null check.
Assignee: nobody → khuey
Flags: needinfo?(khuey)
I was going to file separate bug on Ctrl+Wheel not changing the zoom level, unless
you will leave this bug open to track that issue after fixing the crash. So what is the plan here?
Note: zero relevant bugs found for "e10s zoom level"
(In reply to arni2033 from comment #8)
> I was going to file separate bug on Ctrl+Wheel not changing the zoom level,
> unless
> you will leave this bug open to track that issue after fixing the crash. So
> what is the plan here?

Please file a new bug for that - thanks!
Attachment #8714189 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/45c60b46bab9
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Blocks: 1245068
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.