1244593 - [Web Apps] There has no production Web Apps in app deck

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::TV, defect, P1)

Description

[Mike Lien[:mlien]]

[Description]
We should have production Web Apps after 1/29 in TV

[Reproduce Steps]
1. Launch Apps

[Build Information]
Environment: 2.6 Simulator
gaia: https://github.com/mozilla-b2g/gaia/commit/f0a03a0d46696baf2b7075e1bf5e0afcc55fa8ab
gecko: https://hg.mozilla.org/mozilla-central/rev/b2a3dc4b161fdfac6db78cc5bbfb1f53a383b65a

[Expected Result]
There should have production marketplace app: Web Apps in app deck

[Actual Result]
There has no production marketplace

Comment 1

[Mike Lien[:mlien]]

Hi Fischer, could you help to check it, thanks.

Comment 2

[Fischer [:Fischer]]

@Joseph,
Please check if the production Web Apps is available, thank you.

Comment 3

[Joseph Yeh [:joseph]]

The production manifest.webapp of TV Marketplace is still the wrong version.

However, the marketplace team will have a release every Tuesday, so we can expect the manifest.webapp will be updated tomorrow.

If we need to check-in TV Marketplace to Gaia today, we can use the manifest.webapp on dev server and modify the origin to the production server.

Or we can wait until tomorrow's release.

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] jostw:josyeh/Marketplace/master/Bug1244593 > mozilla-b2g:master

Comment 5

[Joseph Yeh [:joseph]]

Comment on attachment 8715203 [details] [review]
[gaia] jostw:josyeh/Marketplace/master/Bug1244593 > mozilla-b2g:master

Hi Rex,

This patch will land Web Apps (TV Marketplace) into Gaia. Please take a look at it, thanks!

Comment 6

[Mike Lien[:mlien]]

We already behind 2.5 release date but production server still not be shown, I think we should get it ready asap.

Comment 7

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8715203 [details] [review]
[gaia] jostw:josyeh/Marketplace/master/Bug1244593 > mozilla-b2g:master

Looks good to me.

Comment 8

[Mike Lien[:mlien]]

If this doesn't 2.5 blocker? We haven't enable production server on 2.5 yet.

Comment 9

[Joseph Yeh [:joseph]]

Landed in gaia master.

https://github.com/mozilla-b2g/gaia/commit/4178f4489079a222967874db70fe3396ffc3af93

Comment 10

[Joseph Yeh [:joseph]]

Comment on attachment 8715203 [details] [review]
[gaia] jostw:josyeh/Marketplace/master/Bug1244593 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):1244593
[User impact] if declined: No production Web Apps in app deck.
[Testing completed]: Yes
[Risk to taking this patch] (and alternatives if risky): Low
[String changes made]: No

Comment 11

[Josh Cheng [:josh]]

Comment on attachment 8715203 [details] [review]
[gaia] jostw:josyeh/Marketplace/master/Bug1244593 > mozilla-b2g:master

Approve for TV 2.5

Comment 12

[Carsten Book [:Tomcat]]

has conflicts uplifting, can you take a look and provide a 2.5 PR Request, thanks!

Comment 13

[Fischer [:Fischer]]

Joseph, please look at the conflict issue at the comment 12, thanks.

Comment 14

[GitHub Autolander Bot]

Attachment: [gaia] jostw:v2.5 > mozilla-b2g:v2.5

Comment 15

[Joseph Yeh [:joseph]]

Comment on attachment 8722319 [details] [review]
[gaia] jostw:v2.5 > mozilla-b2g:v2.5

Hi Carsten,

I fixed the conflict for v2.5, please take a look. Thanks!

Comment 16

[[e-mail]]

Verify this issue on the latest build.
The production Web Apps are in app deck.

[Build Info]
simulator 2.6.20160222133739
gaia:
https://github.com/mozilla-b2g/gaia/commit/d9faad5c0f14fcd42f920c9104f0638f46a48b2a
gecko:
https://hg.mozilla.org/mozilla-central/rev/789a12291942763bc1e3a89f97e0b82dc1c9d00b

Comment 17

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/b059a19c4cb615e16174735662199e6769cee393