1244629 - Migrate remaining mozL10n.get calls to async in System

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

As the last part of bug 1224063 I have a bunch of lose mozL10n.get calls that we need to migrate.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] zbraniecki:1244629-migrate-remaining-mozl10nget-system > mozilla-b2g:master

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8714237 [details] [review]
[gaia] zbraniecki:1244629-migrate-remaining-mozl10nget-system > mozilla-b2g:master

Etienne, can you review this for me? Tim is OOO until mid-Feb.

I'm trying to move System to L20n to make it future-proof before experimental CD starts picking it up.
That's the last refactor patch needed for this.

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

The Gij 11 and Gij 18 are persistent failures that are not related to this patch.

Comment 4

[Etienne Segonzac (:etienne)]

Comment on attachment 8714237 [details] [review]
[gaia] zbraniecki:1244629-migrate-remaining-mozl10nget-system > mozilla-b2g:master

This doesn't look too scary :)

I'd like to make sure it gets a stamp from the accessibility team too because I know very little about the system's accessibility.js.

But after that you're good to go!

Comment 5

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8714237 [details] [review]
[gaia] zbraniecki:1244629-migrate-remaining-mozl10nget-system > mozilla-b2g:master

Works as expected, thanks (just a couple of nits).

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

Thanks etienne, yzen!

Landed: https://github.com/mozilla-b2g/gaia/commit/309707735c7f81e537c056eb1a243d4a8ce6a78c