Closed Bug 1244629 Opened 6 years ago Closed 6 years ago

Migrate remaining mozL10n.get calls to async in System

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: zbraniecki, Assigned: zbraniecki)

References

Details

Attachments

(1 file)

As the last part of bug 1224063 I have a bunch of lose mozL10n.get calls that we need to migrate.
Assignee: nobody → gandalf
Blocks: 1224063
Comment on attachment 8714237 [details] [review]
[gaia] zbraniecki:1244629-migrate-remaining-mozl10nget-system > mozilla-b2g:master

Etienne, can you review this for me? Tim is OOO until mid-Feb.

I'm trying to move System to L20n to make it future-proof before experimental CD starts picking it up.
That's the last refactor patch needed for this.
Attachment #8714237 - Flags: review?(etienne)
The Gij 11 and Gij 18 are persistent failures that are not related to this patch.
Comment on attachment 8714237 [details] [review]
[gaia] zbraniecki:1244629-migrate-remaining-mozl10nget-system > mozilla-b2g:master

This doesn't look too scary :)

I'd like to make sure it gets a stamp from the accessibility team too because I know very little about the system's accessibility.js.

But after that you're good to go!
Attachment #8714237 - Flags: review?(yzenevich)
Attachment #8714237 - Flags: review?(etienne)
Attachment #8714237 - Flags: review+
Comment on attachment 8714237 [details] [review]
[gaia] zbraniecki:1244629-migrate-remaining-mozl10nget-system > mozilla-b2g:master

Works as expected, thanks (just a couple of nits).
Attachment #8714237 - Flags: review?(yzenevich) → review+
Thanks etienne, yzen!

Landed: https://github.com/mozilla-b2g/gaia/commit/309707735c7f81e537c056eb1a243d4a8ce6a78c
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.