Closed Bug 1244642 Opened 4 years ago Closed 4 years ago

implement AnimationEffectTiming direction

Categories

(Core :: DOM: Animation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: motozawa, Assigned: r_kato)

References

()

Details

Attachments

(3 files)

No description provided.
Assignee: motozawa → daisuke
Assignee: daisuke → foobar094
Comment on attachment 8735077 [details]
MozReview Request: Bug 1244642 - Implement AnimationEffectTiming.direction r?hiro

https://reviewboard.mozilla.org/r/42591/#review39077
Attachment #8735077 - Flags: review?(hiikezoe) → review+
Attachment #8735078 - Flags: review?(hiikezoe) → review+
Comment on attachment 8735078 [details]
MozReview Request: Bug 1244642 - Web-platform tests for AnimationEffectTiming.direction r?hiro

https://reviewboard.mozilla.org/r/42593/#review39081

This is really great!
I think getComputedStyle test should be in getComputedStyle.html.
And I'd like to see a test case that fill:backwards.

r=me with that.
Comment on attachment 8735078 [details]
MozReview Request: Bug 1244642 - Web-platform tests for AnimationEffectTiming.direction r?hiro

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/42593/diff/1-2/
https://reviewboard.mozilla.org/r/42593/#review39081

I've submitted the new test files. These files:

* move tests about getComputedStyle to getComputedStyle.html
* add a test to make sure a value flips when a direction changed.

Thank you for reviewing! ;)
Ryo, these patches cause crashes on MacOS10.10 opt builds on try.  Could you please run the crashing tests on your machine locally?

https://treeherder.mozilla.org/#/jobs?repo=try&revision=86bc8a1546f1
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9a6639d81f87
See M-e10s(5).

Thanks.
Flags: needinfo?(motoryo1)
Attached file crashteste10s.log
I ran the crashing tests with e10s option in local machine (OSX 10.11.4) with this patch. The process was crashed. Attachment file is the log at this time.
Flags: needinfo?(motoryo1)
The e10s crashing test was crashed when I don't apply this patch.
Ryo, thanks! 
The crash was a known issue. https://hg.mozilla.org/integration/mozilla-inbound/rev/d5f3da0cfe7c
Sorry for confusion.
https://hg.mozilla.org/mozilla-central/rev/b51b8d9f8337
https://hg.mozilla.org/mozilla-central/rev/e8e94146b659
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.