1244642 - implement AnimationEffectTiming direction

Status: RESOLVED FIXED

(Core :: DOM: Animation, defect)

Comment 1

[Ryo Kato [:r_kato]]

Attachment: MozReview Request: Bug 1244642 - Implement AnimationEffectTiming.direction r?hiro

Review commit: https://reviewboard.mozilla.org/r/42591/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/42591/

Comment 2

[Ryo Kato [:r_kato]]

Attachment: MozReview Request: Bug 1244642 - Web-platform tests for AnimationEffectTiming.direction r?hiro

Review commit: https://reviewboard.mozilla.org/r/42593/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/42593/

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8735077 [details]
MozReview Request: Bug 1244642 - Implement AnimationEffectTiming.direction r?hiro

https://reviewboard.mozilla.org/r/42591/#review39077

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8735078 [details]
MozReview Request: Bug 1244642 - Web-platform tests for AnimationEffectTiming.direction r?hiro

https://reviewboard.mozilla.org/r/42593/#review39081

This is really great!
I think getComputedStyle test should be in getComputedStyle.html.
And I'd like to see a test case that fill:backwards.

r=me with that.

Comment 5

[Ryo Kato [:r_kato]]

Comment on attachment 8735078 [details]
MozReview Request: Bug 1244642 - Web-platform tests for AnimationEffectTiming.direction r?hiro

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/42593/diff/1-2/

Comment 6

[Ryo Kato [:r_kato]]

https://reviewboard.mozilla.org/r/42593/#review39081

I've submitted the new test files. These files:

* move tests about getComputedStyle to getComputedStyle.html
* add a test to make sure a value flips when a direction changed.

Thank you for reviewing! ;)

Comment 7

[Hiroyuki Ikezoe (:hiro)]

Ryo, these patches cause crashes on MacOS10.10 opt builds on try.  Could you please run the crashing tests on your machine locally?

https://treeherder.mozilla.org/#/jobs?repo=try&revision=86bc8a1546f1
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9a6639d81f87
See M-e10s(5).

Thanks.

Comment 8

[Ryo Motozawa [:ryo]]

Attachment: crashteste10s.log

I ran the crashing tests with e10s option in local machine (OSX 10.11.4) with this patch. The process was crashed. Attachment file is the log at this time.

Comment 9

[Ryo Motozawa [:ryo]]

The e10s crashing test was crashed when I don't apply this patch.

Comment 10

[Hiroyuki Ikezoe (:hiro)]

Ryo, thanks! 
The crash was a known issue. https://hg.mozilla.org/integration/mozilla-inbound/rev/d5f3da0cfe7c
Sorry for confusion.

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b51b8d9f8337
https://hg.mozilla.org/integration/mozilla-inbound/rev/e8e94146b659

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b51b8d9f8337
https://hg.mozilla.org/mozilla-central/rev/e8e94146b659