1244704 - Add another more granular bucket for BOOKMARKS_COUNT probe

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Barbara Bermes [:barbara] - NI please!]

I chatted with the #telemetry team and they pointed me to this file: https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry/Histograms.json#3243

They also mentioned anybody from the Android team can add and request this as well.

I suggest adding another bucket of e.g. 50 in there, otherwise it's really difficult to understand how many bookmarks people are saving.

1-100 is a pretty wide range that doesn't tell us much.

There are a lot of bookmark improvements coming and I'd like to use this probe as one of several others for a KPI.

Comment 1

[:Margaret Leibovic]

Attachment: MozReview Request: Bug 1244704 - Create a more granular BOOKMARKS_COUNT probe for mobile. r=mfinkle

Review commit: https://reviewboard.mozilla.org/r/33005/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33005/

Comment 2

[Barbara Bermes [:barbara] - NI please!]

You are fast. Now I'm thinking...do you think we are bringing Telemetry down if we'd actually by 20 increments buckets (until 100)?

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8714312 [details]
MozReview Request: Bug 1244704 - Create a more granular BOOKMARKS_COUNT probe for mobile. r=mfinkle

https://reviewboard.mozilla.org/r/33005/#review29935

::: toolkit/components/telemetry/Histograms.json:3394
(Diff revision 1)
> +    "n_buckets": 20,

Hopefully this will create more low-end buckets, but I really don't know if one of those buckets will be "0 to 1".

That said, the MDN doc on probes makes it sound like exponential is the right choice:

[[An exponential histogram fits this requirement since it has "narrow" buckets near the minimum value and significantly "wider" buckets near the maximum value.]]

::: toolkit/components/telemetry/Histograms.json:3395
(Diff revision 1)
> +    "releaseChannelCollection": "opt-out",

The PLACES_ version uses "opt-out" too and this probe is not doing anything really different, so it seems safe here.

Comment 4

[:Margaret Leibovic]

(In reply to Barbara Bermes [:barbara] from comment #2)
> You are fast. Now I'm thinking...do you think we are bringing Telemetry down
> if we'd actually by 20 increments buckets (until 100)?

I'm not sure I understand this question... with this patch I am creating more buckets, and I'm creating a low of 0 (instead of 100), which means we'll actually get more granular data in the 0-100 range.

Comment 5

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/5a593c6243325034da9653284b4d72b5eb728c2f
Bug 1244704 - Create a more granular BOOKMARKS_COUNT probe for mobile. r=mfinkle

Comment 6

[Barbara Bermes [:barbara] - NI please!]

So we will now be able to receive a histogram with buckets of 0, 10, 20, 30, 40, etc or even more or less granular? I had originally suggested to do 0, 50, 100 etc. and considered having smaller buckets of 0, 10, 20, 30, 40 etc.

Comment 7

[:Margaret Leibovic]

(In reply to Barbara Bermes [:barbara] from comment #6)
> So we will now be able to receive a histogram with buckets of 0, 10, 20, 30,
> 40, etc or even more or less granular? I had originally suggested to do 0,
> 50, 100 etc. and considered having smaller buckets of 0, 10, 20, 30, 40 etc.

I'm not sure what the math that goes into this looks like, but I think it will be more granular than 0, 50, 100 (probably closer to 0, 10 to start). Since it's exponential, the buckets will get larger and larger.

Comment 8

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/0c62ac10ad8cbbd572deb9fb615cfd5bcf6ee66c
Bug 1244704 - Create a more granular BOOKMARKS_COUNT probe for mobile. r=mfinkle

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0c62ac10ad8c

Comment 10

[:Margaret Leibovic]

Reminder to myself to uplift once we see this data looks like what we want on Nightly.

Comment 11

[:Margaret Leibovic]

Comment on attachment 8714312 [details]
MozReview Request: Bug 1244704 - Create a more granular BOOKMARKS_COUNT probe for mobile. r=mfinkle

Approval Request Comment
[Feature/regressing bug #]: None.

[User impact if declined]: We can't understand how many bookmarks users have.

[Describe test coverage new/current, TreeHerder]: None.

[Risks and why]: Low-risk, updates existing histogram probe.

[String/UUID change made/needed]: None.

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8714312 [details]
MozReview Request: Bug 1244704 - Create a more granular BOOKMARKS_COUNT probe for mobile. r=mfinkle

Should be safe, taking it.
Should be in 45 beta 6.

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/24064776cf06

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/1ffddd837916

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/1ffddd837916