Closed
Bug 1244743
Opened 8 years ago
Closed 8 years ago
Replace MOZ_NATIVE_X with MOZ_SYSTEM_X
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox47 affected, firefox48 fixed)
RESOLVED
FIXED
mozilla48
People
(Reporter: ted, Assigned: ted)
References
Details
Attachments
(1 file)
I don't know where the nomenclature of "MOZ_NATIVE_X" for "--with-system-x" came from, but I can never keep it straight. I'm going to rename these all to the much more understandable "MOZ_SYSTEM_X". I did this with a pair of shell commands: ``` # Find the list of MOZ_NATIVE_FOO find . -type f -not -path '*/\.*' -exec grep MOZ_NATIVE_ "{}" \; | sed -re 's/.*(MOZ_NATIVE_[A-Z0-9]*).*/\1/' | sort -u # Do the replacement find . -type f -not -path '*/\.*' -exec sed -i -r -e 's/MOZ_NATIVE_(NSPR|BZ2|SQLITE|PNG|JPEG|JEMALLOC|ZLIB|LIBVPX|HUNSPELL|FFI|NSS|ICU|LIBEVENT)/MOZ_SYSTEM_\1/g' {} \; ``` In the list I got from the first command there was a "MOZ_NATIVE_DEVICES" that I left out, since it seems to serve a different purpose.
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/33023/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/33023/
Attachment #8714330 -
Flags: review?(gps)
Updated•8 years ago
|
Attachment #8714330 -
Flags: review?(gps) → review+
Comment 2•8 years ago
|
||
Comment on attachment 8714330 [details] MozReview Request: bug 1244743 - Replace MOZ_NATIVE_X with MOZ_SYSTEM_X. r?gps https://reviewboard.mozilla.org/r/33023/#review29855 This is mostly a rubber stamp review since the refactor was mostly automated via sed.
Assignee | ||
Comment 3•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=20e4784bf7f0
Assignee | ||
Comment 4•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ec1879bdc5dc04d4a810c5177be94eb9b3218b9b bug 1244743 - Replace MOZ_NATIVE_X with MOZ_SYSTEM_X. r=gps
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ec1879bdc5dc
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•