1244743 - Replace MOZ_NATIVE_X with MOZ_SYSTEM_X

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(not currently active) Ted Mielczarek]

I don't know where the nomenclature of "MOZ_NATIVE_X" for "--with-system-x" came from, but I can never keep it straight. I'm going to rename these all to the much more understandable "MOZ_SYSTEM_X".

I did this with a pair of shell commands:
```
# Find the list of MOZ_NATIVE_FOO
find . -type f -not -path '*/\.*' -exec grep MOZ_NATIVE_ "{}" \; | sed -re 's/.*(MOZ_NATIVE_[A-Z0-9]*).*/\1/' | sort -u

# Do the replacement
find . -type f -not -path '*/\.*' -exec sed -i -r -e 's/MOZ_NATIVE_(NSPR|BZ2|SQLITE|PNG|JPEG|JEMALLOC|ZLIB|LIBVPX|HUNSPELL|FFI|NSS|ICU|LIBEVENT)/MOZ_SYSTEM_\1/g' {} \;
```

In the list I got from the first command there was a "MOZ_NATIVE_DEVICES" that I left out, since it seems to serve a different purpose.

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: MozReview Request: bug 1244743 - Replace MOZ_NATIVE_X with MOZ_SYSTEM_X. r?gps

Review commit: https://reviewboard.mozilla.org/r/33023/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33023/

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8714330 [details]
MozReview Request: bug 1244743 - Replace MOZ_NATIVE_X with MOZ_SYSTEM_X. r?gps

https://reviewboard.mozilla.org/r/33023/#review29855

This is mostly a rubber stamp review since the refactor was mostly automated via sed.

Comment 3

[(not currently active) Ted Mielczarek]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=20e4784bf7f0

Comment 4

[(not currently active) Ted Mielczarek]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ec1879bdc5dc04d4a810c5177be94eb9b3218b9b
bug 1244743 - Replace MOZ_NATIVE_X with MOZ_SYSTEM_X. r=gps

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ec1879bdc5dc