Closed Bug 1244743 Opened 4 years ago Closed 4 years ago

Replace MOZ_NATIVE_X with MOZ_SYSTEM_X

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox47 affected, firefox48 fixed)

RESOLVED FIXED
mozilla48
Tracking Status
firefox47 --- affected
firefox48 --- fixed

People

(Reporter: ted, Assigned: ted)

References

Details

Attachments

(1 file)

I don't know where the nomenclature of "MOZ_NATIVE_X" for "--with-system-x" came from, but I can never keep it straight. I'm going to rename these all to the much more understandable "MOZ_SYSTEM_X".

I did this with a pair of shell commands:
```
# Find the list of MOZ_NATIVE_FOO
find . -type f -not -path '*/\.*' -exec grep MOZ_NATIVE_ "{}" \; | sed -re 's/.*(MOZ_NATIVE_[A-Z0-9]*).*/\1/' | sort -u

# Do the replacement
find . -type f -not -path '*/\.*' -exec sed -i -r -e 's/MOZ_NATIVE_(NSPR|BZ2|SQLITE|PNG|JPEG|JEMALLOC|ZLIB|LIBVPX|HUNSPELL|FFI|NSS|ICU|LIBEVENT)/MOZ_SYSTEM_\1/g' {} \;
```

In the list I got from the first command there was a "MOZ_NATIVE_DEVICES" that I left out, since it seems to serve a different purpose.
Attachment #8714330 - Flags: review?(gps) → review+
Comment on attachment 8714330 [details]
MozReview Request: bug 1244743 - Replace MOZ_NATIVE_X with MOZ_SYSTEM_X. r?gps

https://reviewboard.mozilla.org/r/33023/#review29855

This is mostly a rubber stamp review since the refactor was mostly automated via sed.
https://hg.mozilla.org/mozilla-central/rev/ec1879bdc5dc
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Depends on: 1262636
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.