Closed Bug 1244786 Opened 5 years ago Closed 5 years ago

mozext import failure

Categories

(Developer Services :: Mercurial: mozext, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mixedpuppy, Assigned: gps)

References

Details

Attachments

(1 file)

*** failed to import extension mozext from /Users/shanec/.mozbuild/version-control-tools/hgext/mozext: No module named requests
hg: unknown command 'pushlogsync'

I have to remove mozext to continue using hg.
Blocks: 1242653
reverting the patch in 1242653 works but gives me this warning while pushlogsync is running:

/Users/shanec/.mozbuild/version-control-tools/pylib/requests/requests/packages/urllib3/util/ssl_.py:90: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. For more information, see https://urllib3.readthedocs.org/en/latest/security.html#insecureplatformwarning.
forgot to add...

following the instructions on readthedocs does not remove the warning.
Assignee: nobody → gps
Status: NEW → ASSIGNED
bootstrap.py exists to configure sys.path with every vendored Python
package path. mozext wasn't using this script - instead it was manually
configuring sys.path.

A recent change to mozautomation introduced requests as a dependency.
Since mozext wasn't inserting pylib/requests into sys.path, this could
result in an import failure due to requests not being found. Using
bootstrap.py adds pylib/requests and makes the ImportError go away.

Review commit: https://reviewboard.mozilla.org/r/33081/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33081/
Attachment #8714436 - Flags: review?(dminor)
Comment on attachment 8714436 [details]
MozReview Request: mozext: use bootstrap.py (bug 1244786); r?dminor

https://reviewboard.mozilla.org/r/33081/#review29827

lgtm
Attachment #8714436 - Flags: review?(dminor) → review+
Autolanded.
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.