1244786 - mozext import failure

Status: RESOLVED FIXED

(Developer Services :: Mercurial: mozext, defect)

Description

[Shane Caraveo (:mixedpuppy)]

*** failed to import extension mozext from /Users/shanec/.mozbuild/version-control-tools/hgext/mozext: No module named requests
hg: unknown command 'pushlogsync'

I have to remove mozext to continue using hg.

Comment 1

[Shane Caraveo (:mixedpuppy)]

reverting the patch in 1242653 works but gives me this warning while pushlogsync is running:

/Users/shanec/.mozbuild/version-control-tools/pylib/requests/requests/packages/urllib3/util/ssl_.py:90: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. For more information, see https://urllib3.readthedocs.org/en/latest/security.html#insecureplatformwarning.

Comment 2

[Shane Caraveo (:mixedpuppy)]

forgot to add...

following the instructions on readthedocs does not remove the warning.

Comment 3

[Gregory Szorc [:gps]]

Attachment: MozReview Request: mozext: use bootstrap.py (bug 1244786); r?dminor

bootstrap.py exists to configure sys.path with every vendored Python
package path. mozext wasn't using this script - instead it was manually
configuring sys.path.

A recent change to mozautomation introduced requests as a dependency.
Since mozext wasn't inserting pylib/requests into sys.path, this could
result in an import failure due to requests not being found. Using
bootstrap.py adds pylib/requests and makes the ImportError go away.

Review commit: https://reviewboard.mozilla.org/r/33081/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33081/

Comment 4

[Dan Minor [:dminor]]

Comment on attachment 8714436 [details]
MozReview Request: mozext: use bootstrap.py (bug 1244786); r?dminor

https://reviewboard.mozilla.org/r/33081/#review29827

lgtm

Comment 5

[Gregory Szorc [:gps]]

Autolanded.