Closed Bug 1244788 Opened 9 years ago Closed 8 years ago

Move loop panel out of browser.xul into add-on

Categories

(Hello (Loop) :: Client, defect, P1)

Product:
Hello (Loop)
Component:
Client
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED INCOMPLETE

People

(Reporter: Mardak, Unassigned)

References

Details

(Whiteboard: [tech-debt][btpp-active][47])

User Story

In our add-on code:

- In bootstrap, on startup for each window (probably in the LoopUI -> initialize function) create a `loop-notification-panel` element
-- Only create if it doesn't already exist (mark this functionality as to support Firefox previous to version "x").
-- Use same attributes as browser.xul has.

That needs to land first (and be shipped to m-c). Then in browser.xul:

- remove loop-notification-panel and loop-panel elements from browser.xul.
When investigating bug 1239965, I noticed the panel#loop-notification-panel is still part of browser.xul. It sounds like it might have been left there accidentally, so we should make it part of the add-on to add to navigator:browsers.
<•Standard8> Mardak: right, I think its loop-panel that isn’t used
Rank: 18
Priority: -- → P1
Whiteboard: [tech-debt][btpp-active]
Why does this block Bug 1239965 ?
Flags: needinfo?(edilee)
Sorry, blocking should be the other way. We'll want to clean this up as bug 1239965 is just cloning the existing panel in m-c.
No longer blocks: 1239965
Depends on: 1239965
Flags: needinfo?(edilee)
Rank: 18 → 21
Priority: P1 → P2
This is probably a simple fix that I think we should do in 47. See user story for stages.
Rank: 21 → 15
User Story: (updated)
Priority: P2 → P1
Whiteboard: [tech-debt][btpp-active] → [tech-debt][btpp-active][47]
Rank: 15 → 23
Support for Hello/Loop has been discontinued. https://support.mozilla.org/kb/hello-status Hence closing the old bugs. Thank you for your support.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.