1244805 - Relative URLs cause access errors at install time

Status: VERIFIED FIXED

(WebExtensions :: Untriaged, defect)

Description

[Kris Maglione [:kmag]]

We resolve relative URLs in manifests relative to the filesystem URL when validating them from the add-on manager. Since file: URLs aren't loadable by the null principal, this causes access errors.

This should have been caught by our tests, but they don't currently run the same startup checks as the add-on manager for every test add-on.

Comment 1

[Kris Maglione [:kmag]]

Attachment: MozReview Request: Bug 1244805: [webext] Don't resolve relative URLs in manifests unless extension is running. r?billm

Review commit: https://reviewboard.mozilla.org/r/33065/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33065/

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8714398 [details]
MozReview Request: Bug 1244805: [webext] Don't resolve relative URLs in manifests unless extension is running. r?billm

https://reviewboard.mozilla.org/r/33065/#review29829

Comment 3

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/fx-team/rev/184854a1ca0e5a89a380d1976dd1f678d633e48f
Bug 1244805: [webext] Don't resolve relative URLs in manifests unless extension is running. r=billm

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/184854a1ca0e

Comment 6

[Vasilica Tamas, QA [:vtamas]]

Could you please provide some steps in order to manually verify this bug?

Comment 7

[Kris Maglione [:kmag]]

This bug has been pretty thoroughly verified, I think.