1244820 - Audit NotificationHelper, e.g. why do we try to clear all notifications in onDestroy?

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

I wrote this for bug 1075476 comment 37:

On another note, I'm surprised the mClearableNotifications information is stored in memory – once we get OOM'd, we won't have this information anymore and we'll act inconsistently from when FF is in memory. It looks like we use this information to close all of our notifications when GeckoApp.onDestroy is called but GeckoApp.onDestroy is not guaranteed to be called. Also, I'm not sure why we'd want to clear all of the notifications when GeckoApp is destroyed... This seems fishy.
---

Basically, figure out what we're doing in NotificationHelper & make sure it's correct.

Comment 1

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.