Closed
Bug 1245031
Opened 10 years ago
Closed 10 years ago
[Presentation WebAPI] Add missing test receiver files
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla47
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | fixed |
People
(Reporter: selin, Assigned: selin)
References
Details
Attachments
(1 file, 1 obsolete file)
|
5.31 KB,
patch
|
schien
:
review+
|
Details | Diff | Splinter Review |
In bug 1215426, a new test receiver file should have been added to verify the availability of Presentation API in an inner iframe with the same origin as the browsing receiving page. [1] But somehow it was missing in the patch and didn't get checked in to the code base. We'd better to add it back to cover this test scenario.
[1] https://dxr.mozilla.org/mozilla-central/source/dom/presentation/tests/mochitest/file_presentation_receiver_oop.html#60
| Assignee | ||
Updated•10 years ago
|
Blocks: 2-UA_Presentation_API
| Assignee | ||
Comment 1•10 years ago
|
||
Adding missing test files.
Comment 2•10 years ago
|
||
Comment on attachment 8714698 [details] [diff] [review]
Patch, v1
Review of attachment 8714698 [details] [diff] [review]:
-----------------------------------------------------------------
lgtm!
Attachment #8714698 -
Flags: review?(schien) → review+
| Assignee | ||
Comment 3•10 years ago
|
||
Disabling the test for same-origin inner iframe for now, since it might be affected by the same root cause of bug 1234128 and cause intermittent failures.
Attachment #8714698 -
Attachment is obsolete: true
Attachment #8721883 -
Flags: review?(schien)
Comment 4•10 years ago
|
||
Comment on attachment 8721883 [details] [diff] [review]
Patch, v2
Review of attachment 8721883 [details] [diff] [review]:
-----------------------------------------------------------------
lgtm!
Attachment #8721883 -
Flags: review?(schien) → review+
| Assignee | ||
Comment 5•10 years ago
|
||
The latest try-run. FYI.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=df4811e4d2b5
Keywords: checkin-needed
Keywords: checkin-needed
Comment 7•10 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Updated•7 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•