Closed Bug 1245036 Opened 9 years ago Closed 9 years ago

Add columns test case for <summary> element

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla48
Tracking Flags:
Tracking Status
firefox47 --- affected
firefox48 --- fixed

People

(Reporter: TYLin, Assigned: TYLin)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

MozReview Request: Bug 1245036 Part 1 - Use default-preferences in details and summary reftest.list.
58 bytes, text/x-review-board-request
bzbarsky
: review+
Details
MozReview Request: Bug 1245036 Part 2 - Add columns test case for <summary> element.
58 bytes, text/x-review-board-request
bzbarsky
: review+
Details
Per bug 591737 comment comment 220, this is a follow-up to support css columns for <summary> elements. After bug 591737 landed, <details> should already support css columns.
After bug 1258657 landed, the summary element is rendered by nsBlockFrame, so it supports css columns for free.
Assignee: nobody → tlin
Status: NEW → ASSIGNED
Summary: Add columns support to <summary> element → Add columns test case for <summary> element
After bug 1258657 landed, summary element is rendered by nsBlockFrame, so it supports css columns for free. Review commit: https://reviewboard.mozilla.org/r/46365/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/46365/
Attachment #8741306 - Flags: review?(bzbarsky)
Attachment #8741306 - Flags: review?(bzbarsky)
Comment on attachment 8741306 [details] MozReview Request: Bug 1245036 - Add columns test case for <summary> element. https://reviewboard.mozilla.org/r/46365/#review43031 I think it would be better to have a separate testcase for summary here, instead of dealing with the mess that is nested columnsets.
Turn on the pref at once instead of duplicating the line in every single tests. Review commit: https://reviewboard.mozilla.org/r/46639/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/46639/
Attachment #8741621 - Flags: review?(bzbarsky)
Attachment #8741622 - Flags: review?(bzbarsky)
After bug 1258657 landed, summary element is rendered by nsBlockFrame, so it supports css columns for free. Review commit: https://reviewboard.mozilla.org/r/46641/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/46641/
Attachment #8741306 - Attachment is obsolete: true
Comment on attachment 8741621 [details] MozReview Request: Bug 1245036 Part 1 - Use default-preferences in details and summary reftest.list. https://reviewboard.mozilla.org/r/46639/#review43393 r=me
Attachment #8741621 - Flags: review?(bzbarsky) → review+
Comment on attachment 8741622 [details] MozReview Request: Bug 1245036 Part 2 - Add columns test case for <summary> element. https://reviewboard.mozilla.org/r/46641/#review43397 r=me
Attachment #8741622 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/65c479a60775 https://hg.mozilla.org/mozilla-central/rev/aaa5e560ed43
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: