Remove workarounds for assembly using r7 on thumb

RESOLVED FIXED in Firefox 47

Status

()

Core
Build Config
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla47
Points:
---

Firefox Tracking Flags

(firefox47 fixed)

Details

Attachments

(2 attachments)

Comment hidden (empty)
(Assignee)

Comment 1

2 years ago
Created attachment 8714734 [details] [diff] [review]
Remove toolkit/crashreporter/google-breakpad/src/client/linux/handler/Makefile.in
Attachment #8714734 - Flags: review?(mshal)
(Assignee)

Comment 2

2 years ago
Created attachment 8714735 [details] [diff] [review]
Remove gfx/skia/Makefile.in
Attachment #8714735 - Flags: review?(mshal)
Comment on attachment 8714734 [details] [diff] [review]
Remove toolkit/crashreporter/google-breakpad/src/client/linux/handler/Makefile.in

This seems reasonable. How many times did you test it? I can't tell from bug 633436 how inconsistent the original error was, and the comment just says that it "complains inconsistently". I guess if it's still an issue we'd find out pretty quickly and can add the flag to moz.build
Attachment #8714734 - Flags: review?(mshal) → review+

Updated

2 years ago
Attachment #8714735 - Flags: review?(mshal) → review+
(Assignee)

Comment 4

2 years ago
Yeah, I don't know what the "inconsistently" is supposed to mean, but I see no reason why the compiler would complain randomly. Either it does or it does not. And it does not in any of the android arm builds, opt of debug, with or without profiling enabled. So...

Comment 5

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/5598f6f12520
https://hg.mozilla.org/integration/mozilla-inbound/rev/82adb48a15e7

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5598f6f12520
https://hg.mozilla.org/mozilla-central/rev/82adb48a15e7
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.