Option to build B2G as 32bit on a 64_32 multilib build target

RESOLVED WONTFIX

Status

defect
RESOLVED WONTFIX
3 years ago
Last year

People

(Reporter: afarden, Assigned: afarden)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 2 obsolete attachments)

Assignee

Description

3 years ago
On some build targets Gecko does not build as 64bit correctly. 64bit Android is backwards compatible with 32bit binaries so while we fix Gecko for 64bit we can optionally build Gecko for devices as 32bit.

This means we don't have to hold those devices back until Gecko is fixed.

Set build flag: BUILD_MULTILIB_GECKO_AS_2ND_ARCH := true
Assignee

Comment 1

3 years ago
Posted file Gonk PR
Attachment #8714786 - Flags: review?(mwu)
Assignee

Comment 2

3 years ago
Posted patch Gecko Patch (obsolete) — Splinter Review
Attachment #8714788 - Flags: review?(mwu)
Assignee

Comment 3

3 years ago
I've been using these patches for many weeks to build both 32bit and 64bit devices without issue!
Assignee

Updated

3 years ago
Blocks: 1187826

Updated

3 years ago
Attachment #8714786 - Flags: review?(mwu) → review+

Updated

3 years ago
Attachment #8714788 - Flags: review?(mwu) → review+
Assignee

Updated

3 years ago
Keywords: checkin-needed
Assignee

Updated

3 years ago
Assignee: nobody → afarden
seems we need to wait here till the gonk changes also land with the bumper bot on mozilla-inbound
Hi, adam, Fabrice

i talked with my manager and sheriff stopped support for Fxos checkin needed requests per the tier3 change and so it would be cool if someone from the fxos group/cd group with level 3 scm access could take over this task for checkin needed requests. Thanks
fabrice could you (or someone else from the fxos team) land this to b2g-inbound so the both changes come together, since we sheriffs don't do checkin needed requests for fxos anymore (see comment #5)
Flags: needinfo?(fabrice)
Adam, is there any particular order to land these?
Flags: needinfo?(afarden)
Assignee

Comment 8

3 years ago
gonk-misc should land first because we're exporting a new variable to Gecko to set the $OUT path according to which ARCH we build against.

Existing builds will continue to work fine when gonk-misc is merged but gecko has not landed, but build will break if gecko is merged first due to lack of exported variable.
Flags: needinfo?(fabrice)
Flags: needinfo?(afarden)
Assignee

Comment 12

3 years ago
Posted file Gonk PR Part 2 (obsolete) —
Attachment #8726606 - Flags: review?(mwu)
Assignee

Comment 13

3 years ago
Posted patch Gecko PatchSplinter Review
Attachment #8714788 - Attachment is obsolete: true
Attachment #8726608 - Flags: review?(mwu)
Assignee

Comment 14

3 years ago
Posted file Gonk Patch
Adding the second Gonk patch here in case my PR one day disappears.
Attachment #8726606 - Attachment is obsolete: true
Attachment #8726606 - Flags: review?(mwu)
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.