1245100 - Missing includes in SystemProperty.cpp

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 1245100: Include missing headers in SystemProperty.cpp

Comment 2

[Edgar Chen [:edgar]]

Comment on attachment 8714795 [details] [diff] [review]
[01] Bug 1245100: Include missing headers in SystemProperty.cpp

Review of attachment 8714795 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you.
Just curious is there any build error caused by this? I thought b2g build is good now [1].

[1] https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&exclusion_profile=false&group_state=expanded&filter-searchStr=b2g&selectedJob=20946756

Comment 3

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Hi,

The current code got these headers from a different file via the unified-sources mechanism. When I added a source file to this directory, the build system the groups in which source files where built, and so SystemProperty.cpp lost the implicit includes.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d5f33d0117d4

Comment 5

[Thomas Zimmermann [:tzimmermann] [:tdz]]

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=d5f33d0117d4

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d5f33d0117d4