Closed Bug 1245136 Opened 4 years ago Closed 4 years ago

Discard old-format pending Telemetry files

Categories

(Toolkit :: Telemetry, defect, P4)

defect

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: gfritzsche, Assigned: hharchani, Mentored)

References

(Blocks 1 open bug)

Details

(Whiteboard: [measurement:client] [lang=js])

Attachments

(1 file)

When updating the Telemetry implementation, we added code to handle pending old-format pings:
https://dxr.mozilla.org/mozilla-central/rev/584870f1cbc5d060a57e147ce249f736956e2b62/toolkit/components/telemetry/TelemetryStorage.jsm#1580

We should just remove that code and let the pings be removed.

The tests to check these changes are run with:
mach test toolkit/components/telemetry/tests/unit

There might be test failure after these changes, we should just review & update those tests.
Priority: -- → P4
I ran this test
mach test toolkit/components/telemetry/tests/unit

It passed successfully.
This is the output of running test, before and after the patch
https://pastebin.mozilla.org/8861997
Assignee: nobody → hharchani
Comment on attachment 8725991 [details] [diff] [review]
Discard old-format pending Telemetry files,

Review of attachment 8725991 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good, thank you!

Note that you can request "review" for your patches from specific people when uploading a patch.
That way an email is sent out for it and it shows up in our lists of request in Bugzilla here.
Attachment #8725991 - Flags: review+
This passes tests fine locally and i expect no difference on try and other platforms - marking this for check-in.
Status: NEW → ASSIGNED
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/860645097658
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.