1245136 - Discard old-format pending Telemetry files

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P4)

Description

[Georg Fritzsche [:gfritzsche]]

When updating the Telemetry implementation, we added code to handle pending old-format pings:
https://dxr.mozilla.org/mozilla-central/rev/584870f1cbc5d060a57e147ce249f736956e2b62/toolkit/components/telemetry/TelemetryStorage.jsm#1580

We should just remove that code and let the pings be removed.

The tests to check these changes are run with:
mach test toolkit/components/telemetry/tests/unit

There might be test failure after these changes, we should just review & update those tests.

Comment 1

[hharchani]

Attachment: Discard old-format pending Telemetry files,

I ran this test
mach test toolkit/components/telemetry/tests/unit

It passed successfully.
This is the output of running test, before and after the patch
https://pastebin.mozilla.org/8861997

Comment 2

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8725991 [details] [diff] [review]
Discard old-format pending Telemetry files,

Review of attachment 8725991 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good, thank you!

Note that you can request "review" for your patches from specific people when uploading a patch.
That way an email is sent out for it and it shows up in our lists of request in Bugzilla here.

Comment 3

[Georg Fritzsche [:gfritzsche]]

This passes tests fine locally and i expect no difference on try and other platforms - marking this for check-in.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/860645097658

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/860645097658