1245141 - Use `new Proxy` for AddonManager.addonTypes

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Tom S]

Attachment: v1 - Change Proxy.create to new Proxy in AddonManagerInternal

Comment 1

[Dave Townsend [:mossop]]

Comment on attachment 8714863 [details] [diff] [review]
v1 - Change Proxy.create to new Proxy in AddonManagerInternal

Review of attachment 8714863 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/mozapps/extensions/AddonManager.jsm
@@ +2675,5 @@
> +      setPrototypeOf(target, prototype) {
> +        // Not allowed to change prototype
> +        return false;
> +      }
> +    });

Why does this create a new proxy every time?

Comment 2

[Tom S]

Because we need a reference to AddonManagerInternal.types, which we can't get during initialization. We can't cache the proxy on AddonManagerInternal, because that object seems to be frozen. However this would work:

let types = {}
let AddonManagerInternal = {
...
 types,
...
 typesProxy: new Proxy(types, {...})
...
}

Or we could move typesProxy to a global variable.

Comment 3

[Dave Townsend [:mossop]]

Comment on attachment 8714863 [details] [diff] [review]
v1 - Change Proxy.create to new Proxy in AddonManagerInternal

Review of attachment 8714863 [details] [diff] [review]:
-----------------------------------------------------------------

I guess it doesn't matter much

Comment 4

[Tom S]

Attachment: v2 - Change Proxy.create to new Proxy in AddonManagerInternal

Turns out that the previous Proxy actually modified that value returned for [[Get]]. (We always return the `type` property) Sorry about that, but I did a try push this time. https://treeherder.mozilla.org/#/jobs?repo=try&revision=cc284c8eb5b7

Comment 5

[Tom S]

Attachment: v2 - Change Proxy.create to new Proxy in AddonManagerInternal

Ups, right patch this time.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6515133eb252

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/6515133eb252