1245192 - [e10s] Need to block Skype Click to Call users from participating in Beta 45 Telemetry Experiment

Status: RESOLVED FIXED

(Firefox :: Extension Compatibility, defect)

Description

[Erin Lancaster [:elan]]

Based on KaiRo's Findings: 
Bug 1210099 (mozilla::OriginAttributes::CreateSuffix) is 7.5% of all crashes in 45.0b1, almost all at startup, 5 crashes per installation, #1 Top Crash Score by far. All seem to have e10s on and most have Skype Click-to-Call installed.

To be fair, this is a pre-release channel so we also need to contact Skype about the crash

Comment 1

[:Felipe Gomes (needinfo for replies!)]

So to do this I need the add-on id of the add-on mentioned, and possibly the version range unless we want all versions included.

Note that what we will do is to remove Skype Click-To-Call users from the experiment and return them to non-e10s.

Comment 2

[Erin Lancaster [:elan]]

From KaiRo: 
82AF8DCA-6DE9-405D-BD5E-43525BDAD38A} is the ID, see https://bugzilla.mozilla.org/show_bug.cgi?id=1210099#c28

7.5.0.9082 and 8.0.0.9103 are crashing, and I think the latter is actually their newest version, from looking at the data we have

HTH!

Comment 3

[:Felipe Gomes (needinfo for replies!)]

Thanks! Since both an older and the newer version are crashing, I'm inclined to block all version from the experiment.

From that comment, do we also want to block the avast add-on? Or wait and see?

Comment 4

[:Felipe Gomes (needinfo for replies!)]

Attachment: patch

I have verified locally that a change in the filter.js file to return false does trigger an uninstall in the experiment system, and that our add-on code is correctly clearing the e10s pref when uninstalled.

Comment 5

[Jorge Villalobos [:jorgev] (he/him)]

Note that we're in contact with Skype/Microsoft in bug 1215970. I'll let them know about this new crash.

Comment 6

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8714951 [details] [diff] [review]
patch

Review of attachment 8714951 [details] [diff] [review]:
-----------------------------------------------------------------

I guess if this helps we should do it. I doubt this add-on is actually responsible for the crash though.

Comment 7

[:Felipe Gomes (needinfo for replies!)]

https://hg.mozilla.org/webtools/telemetry-experiment-server/rev/1fcbbe2c1e35
https://hg.mozilla.org/webtools/telemetry-experiment-server/rev/ca06c3e9872f

Filed deployment bug as 1245300

Comment 8

[:Felipe Gomes (needinfo for replies!)]

Block deployed. Users with this add-on id should be taken out of the experiment, as long as the crash doesn't happen too early in the startup that they can't get the updated manifest.