1245217 - (iOS-L10N-Snapshots) [meta] Generate L10N Screenshots

Status: NEW

(Firefox for iOS :: General, defect)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

This bug is to collect all bugs about creating L10N Snapshots. Just make the more detailed snapshot request block this one.

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: PR: https://github.com/mozilla/firefox-ios/pull/1594

This patch improves L10N snapshots. The output can be seen at:

http://people.mozilla.org/~sarentz/fxios/screenshots/

Making incremental changes to get more coverage.

* Adds screenshots for lots of empty states
* Adds a l10n-screenshots.sh script to run them for a number of locales
* Adds `accessibilityIdentifier`s where needed
* Introduces a MOZ_SKIP_WHATSNEW environment variable that UI tests can use

I'll squash all the commits into one before merging this.

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Going to add a number of incremental PRs to this bug to get L10N screenshotting in a good state.

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8725872 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/1594

Updated patch. Many commits rebased into single commits:


This patch improves L10N snapshots. The output can be seen at:

http://people.mozilla.org/~sarentz/fxios/screenshots/

This patch now has three main parts:

* Adding more accessibility identifiers throughout the UI code. These are needed to properly locate UI elements.
* The `TestAppDelegate` and `main.swift` are now aware when the app is run as part of a *Fastlane Snapshot* test. In that case the `TestAppDelegate` is used. And we skip the *What's New* page.
* Added a bunch more snapshot test cases to get better coverage of the application

The last commit in the patch is about adding `l10n-screenshots.sh`, which is a *temporary* script to run these screenshots. This only exists because I can't get Fastlane to work. I'm also happy to remove this script from this patch and just run a local copy until we have resolved the Fastlane issues.

Comment 4

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

I removed the hacks to disable things like What's new and the code to clean the profile. This is now handled by the TestAppDelegate that we already have. I only made it aware of Fastlane Snapshot tests and we do not skip the Intro in that case because that is something we actually want to screenshot.

Comment 5

[Brian Nicholson (:bnicholson)]

Comment on attachment 8725872 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/1594

Looks fine to me!

Comment 6

[Emily Toop (:fluffyemily)]

Attachment: Pull request

Helping getting fastlane snapshotting back up and running by fixing some issues

Comment 7

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8727816 [details]
Pull request

LGTM

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.