Bug 1245217 (iOS-L10N-Snapshots)

[meta] Generate L10N Screenshots

ASSIGNED
Assigned to

Status

()

ASSIGNED
3 years ago
3 years ago

People

(Reporter: st3fan, Assigned: st3fan)

Tracking

(Depends on: 12 bugs)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
This bug is to collect all bugs about creating L10N Snapshots. Just make the more detailed snapshot request block this one.
(Assignee)

Updated

3 years ago
Depends on: 1245219
(Assignee)

Comment 1

3 years ago
Created attachment 8725872 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/1594

This patch improves L10N snapshots. The output can be seen at:

http://people.mozilla.org/~sarentz/fxios/screenshots/

Making incremental changes to get more coverage.

* Adds screenshots for lots of empty states
* Adds a l10n-screenshots.sh script to run them for a number of locales
* Adds `accessibilityIdentifier`s where needed
* Introduces a MOZ_SKIP_WHATSNEW environment variable that UI tests can use

I'll squash all the commits into one before merging this.
Attachment #8725872 - Flags: review?(etoop)
Attachment #8725872 - Flags: review?(bnicholson)
(Assignee)

Comment 2

3 years ago
Going to add a number of incremental PRs to this bug to get L10N screenshotting in a good state.
(Assignee)

Comment 3

3 years ago
Comment on attachment 8725872 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/1594

Updated patch. Many commits rebased into single commits:


This patch improves L10N snapshots. The output can be seen at:

http://people.mozilla.org/~sarentz/fxios/screenshots/

This patch now has three main parts:

* Adding more accessibility identifiers throughout the UI code. These are needed to properly locate UI elements.
* The `TestAppDelegate` and `main.swift` are now aware when the app is run as part of a *Fastlane Snapshot* test. In that case the `TestAppDelegate` is used. And we skip the *What's New* page.
* Added a bunch more snapshot test cases to get better coverage of the application

The last commit in the patch is about adding `l10n-screenshots.sh`, which is a *temporary* script to run these screenshots. This only exists because I can't get Fastlane to work. I'm also happy to remove this script from this patch and just run a local copy until we have resolved the Fastlane issues.
(Assignee)

Comment 4

3 years ago
I removed the hacks to disable things like What's new and the code to clean the profile. This is now handled by the TestAppDelegate that we already have. I only made it aware of Fastlane Snapshot tests and we do not skip the Intro in that case because that is something we actually want to screenshot.
Comment on attachment 8725872 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/1594

Looks fine to me!
Attachment #8725872 - Flags: review?(bnicholson) → review+
Assignee: nobody → sarentz
Status: NEW → ASSIGNED
Attachment #8725872 - Flags: review?(etoop) → review+
Created attachment 8727816 [details]
Pull request

Helping getting fastlane snapshotting back up and running by fixing some issues
Attachment #8727816 - Flags: review?(sarentz)
(Assignee)

Updated

3 years ago
Depends on: 1254794
(Assignee)

Comment 7

3 years ago
Comment on attachment 8727816 [details]
Pull request

LGTM
Attachment #8727816 - Flags: review?(sarentz) → review+
(Assignee)

Updated

3 years ago
Depends on: 1255249
(Assignee)

Updated

3 years ago
Depends on: 1257831
(Assignee)

Updated

3 years ago
Depends on: 1257955
(Assignee)

Updated

3 years ago
Summary: [Meta] L10N Snapshots → Generate L10N Screenshots
(Assignee)

Updated

3 years ago
Depends on: 1254695
(Assignee)

Updated

3 years ago
Depends on: 1254792
(Assignee)

Updated

3 years ago
Depends on: 1254799
(Assignee)

Updated

3 years ago
Depends on: 1257966
(Assignee)

Updated

3 years ago
Alias: iosl10nsnapshots
(Assignee)

Updated

3 years ago
Depends on: 1258024
(Assignee)

Updated

3 years ago
Depends on: 1258025
(Assignee)

Updated

3 years ago
Depends on: 1258026
(Assignee)

Updated

3 years ago
Depends on: 1258032
(Assignee)

Updated

3 years ago
Depends on: 1258040
(Assignee)

Updated

3 years ago
Depends on: 1258042
(Assignee)

Updated

3 years ago
Depends on: 1258044
(Assignee)

Updated

3 years ago
Depends on: 1258047
(Assignee)

Updated

3 years ago
Depends on: 1258048
(Assignee)

Updated

3 years ago
Depends on: 1258049
(Assignee)

Updated

3 years ago
Depends on: 1258050
(Assignee)

Updated

3 years ago
Alias: iosl10nsnapshots → iOS-L10N-Snapshots
(Assignee)

Updated

3 years ago
Summary: Generate L10N Screenshots → [meta] Generate L10N Screenshots

Updated

3 years ago
Depends on: 1263102
You need to log in before you can comment on or make changes to this bug.