Closed
Bug 1245218
Opened 10 years ago
Closed 10 years ago
Use format() to generate thousands separator strings
Categories
(Socorro :: Webapp, task)
Socorro
Webapp
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: peterbe, Unassigned)
References
Details
Attachments
(1 file)
Our helper function digitgroupseparator() is overly complicated.
https://github.com/mozilla/socorro/blob/0c7536acec0dd6cfbf4c3521b977a44368f871ff/webapp-django/crashstats/crashstats/helpers.py#L37
This can most likely be replaced with simply doing; `return format(n, ',')`
See https://github.com/peterbe/django-peterbecom/blob/252cf8484abf5bdff37cb5018c0776c3aa9698c7/peterbecom/apps/stats/helpers.py#L5
|
Reporter | |
Comment 1•10 years ago
|
||
|
||
Comment 2•10 years ago
|
||
Commits pushed to master at https://github.com/mozilla/socorro
https://github.com/mozilla/socorro/commit/ef9e4d22eee562814f5f6c551222300693da8699
fixes bug 1245218 - Use format() to generate thousands separator strings
https://github.com/mozilla/socorro/commit/7b0453a3ce07197872555148a41e25e016d38377
Merge pull request #3187 from peterbe/bug-1245218-use-format-to-generate-thousands-separator-strings
fixes bug 1245218 - Use format() to generate thousands separator strings
|
|
||
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•