1245251 - Add-on startup fails for external XUL apps

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

After bug 1203159, DevTools files were moved around such that the line:

if (Cu.isModuleLoaded("resource://devtools/client/framework/ToolboxProcess.jsm")) {

in XPIProvider.jsm now throws for external XUL apps.

I believe the cause is that resource://devtools is not defined because no chrome.manifest that defines it is currently loaded by such apps.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

I have confirmed it's because of the missing resource definition.

That means this occurs back to 44.  Not sure if we'll uplift since only external XUL apps are impacted.

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ac11bf902bcb

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: MozReview Request: Bug 1245251 - Repair add-on manager for external XUL apps. r=Mossop

MozReview-Commit-ID: HY8lrjB9Mts

Review commit: https://reviewboard.mozilla.org/r/33303/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33303/

Comment 4

[Dave Townsend [:mossop] (PTO until Aug 21st)]

Comment on attachment 8714994 [details]
MozReview Request: Bug 1245251 - Repair add-on manager for external XUL apps. r=Mossop

https://reviewboard.mozilla.org/r/33303/#review30157

Swallowing all exceptions isn't ideal, it might make us break something and never realise it. Instead can you get the resource protocol handler and use hasSubstitution("devtools") to guard that block?

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8714994 [details]
MozReview Request: Bug 1245251 - Repair add-on manager for external XUL apps. r=Mossop

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33303/diff/1-2/

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ba70e1f017ff

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9615838e42c4

Comment 8

[Dave Townsend [:mossop] (PTO until Aug 21st)]

Comment on attachment 8714994 [details]
MozReview Request: Bug 1245251 - Repair add-on manager for external XUL apps. r=Mossop

https://reviewboard.mozilla.org/r/33303/#review30357

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/0fef19424561

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/0fef19424561

Comment 11

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8714994 [details]
MozReview Request: Bug 1245251 - Repair add-on manager for external XUL apps. r=Mossop

Approval Request Comment
[Feature/regressing bug #]: The regression was introduced by bug 1203159.
[User impact if declined]: There is no direct impact to Mozilla products if declined.  This issue only affects external XUL apps which are currently instructed to use Firefox builds with "firefox --app" to run their applications.  For those external XUL apps, the add-on manager will fail at startup and the application itself could break as well.
[Describe test coverage new/current, TreeHerder]: No new tests, I tested manually to confirm issue is resolved.  Landed on m-c.
[Risks and why]: Low risk, adds a check to ensure a path exists before using it.
[String/UUID change made/needed]: None

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8714994 [details]
MozReview Request: Bug 1245251 - Repair add-on manager for external XUL apps. r=Mossop

Taking it as 45 is an ESR. Should be in 45 beta 4.

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4cec5d9097c4

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0558da46f20c