1245285 - Prevent AsyncPanZoomController from repainting Zoom and Overscroll animations until animation has completed

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Comment 1

[Randall Barker [:rbarker]]

This code is left over from when C++APZ did not send continuous repaint requests during animations.

Comment 2

[Randall Barker [:rbarker]]

Attachment: 0001-Bug-1245285-AsyncPanZoomController-ZoomToRect-needlessly-sends-repaint-request-for-final-FrameMetric-state-r-16020214-9ae9978.patch

Comment 3

[Randall Barker [:rbarker]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=98d1e5538b73

Comment 4

[Botond Ballo [:botond]]

Comment on attachment 8715022 [details] [diff] [review]
0001-Bug-1245285-AsyncPanZoomController-ZoomToRect-needlessly-sends-repaint-request-for-final-FrameMetric-state-r-16020214-9ae9978.patch

Review of attachment 8715022 [details] [diff] [review]:
-----------------------------------------------------------------

We had an IRC discussion about this. The conclusion was that it would be better to avoid per-frame repaints for zoom animations, and keep this ahead-of-time repaint for the final resolution.

Comment 5

[Randall Barker [:rbarker]]

Attachment: 0001-Bug-1245285-part-1-Remove-unused-mRepaintInterval-from-AsyncPanZoomAnimation-r-16020312-3ed97b7.patch

Comment 6

[Randall Barker [:rbarker]]

Attachment: 0002-Bug-1245285-part-2-Prevent-Zoom-and-Overscroll-animations-from-repainting-durring-animation-r-16020312-9c339003.patch

Comment 7

[Botond Ballo [:botond]]

Comment on attachment 8715470 [details] [diff] [review]
0001-Bug-1245285-part-1-Remove-unused-mRepaintInterval-from-AsyncPanZoomAnimation-r-16020312-3ed97b7.patch

Review of attachment 8715470 [details] [diff] [review]:
-----------------------------------------------------------------

As a follow-up, please remove the prefs apz.fling_repaint_interval and apz.smooth_scroll_repaint_interval (the declaration in gfxPrefs.h, the description in AsyncPanZoomController.cpp, and lines setting it in modules/libpref/init/all.js).

And since we're cleaning up anyways, might as well do the same for apz.pan_repaint_interval, which is already unused.

Comment 8

[Botond Ballo [:botond]]

Comment on attachment 8715471 [details] [diff] [review]
0002-Bug-1245285-part-2-Prevent-Zoom-and-Overscroll-animations-from-repainting-durring-animation-r-16020312-9c339003.patch

Review of attachment 8715471 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 9

[Randall Barker [:rbarker]]

Attachment: 0003-Bug-1245285-part-3-Remove-unused-repaint_interval-prefs-r-16020313-8cc03b5.patch

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/41ea5de656a9
https://hg.mozilla.org/integration/mozilla-inbound/rev/a211643de3b6
https://hg.mozilla.org/integration/mozilla-inbound/rev/e0c8fb70a095

Comment 11

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/a4e1258bc299 - e10s wasn't happy, frequent https://treeherder.mozilla.org/logviewer.html#?job_id=21051744&repo=mozilla-inbound and https://treeherder.mozilla.org/logviewer.html#?job_id=21048046&repo=mozilla-inbound

Comment 12

[Kartikaya Gupta (email:[e-mail])]

Those failures are more likely to be from my bug 990916. I'll take a look.

Comment 13

[Kartikaya Gupta (email:[e-mail])]

I filed bug 1245830 for the intermittent failure. Personally I think you should be able to reland this but the sheriffs might prefer that I land the fix for the intermittent first (or they might want to back out bug 990916 but as the intermittent seems low-volume I hope not).

Comment 14

[Phil Ringnalda (:philor)]

Yes, you can reland, sorry for the churn, I was nearly asleep and not doing things right.

Comment 15

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7e7eb92b6856
https://hg.mozilla.org/integration/mozilla-inbound/rev/4436ae606459
https://hg.mozilla.org/integration/mozilla-inbound/rev/c9506e817fe1

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7e7eb92b6856
https://hg.mozilla.org/mozilla-central/rev/4436ae606459
https://hg.mozilla.org/mozilla-central/rev/c9506e817fe1