Closed Bug 1245304 Opened 6 years ago Closed 6 years ago

Add releng build file containing Adjust SDK private app token for Beta builds

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(firefox45+ wontfix, firefox46+ wontfix, firefox47+ fixed)

RESOLVED FIXED
Firefox 47
Tracking Status
firefox45 + wontfix
firefox46 + wontfix
firefox47 + fixed

People

(Reporter: mcomella, Assigned: Callek)

References

Details

Attachments

(4 files)

From bug 1244930 comment 6:

> If we wanted to separate the releases (which might not be a bad idea), we would
> need to give Beta a different App ID with Adjust.

> I created a new app and token just now. You should get an email from Adjust in
> a moment moment with details.

Email received, I'll take a look later. Assigning so I don't forget but if you want to fix it sooner, feel free to take it!
This ticket is identical to Bug 1152871, except we want a new private app token for Firefox for Android Beta builds.

mfinkle will encrypt the token and send it to coop, as per https://bugzilla.mozilla.org/show_bug.cgi?id=1152871#c4.  Mark, I'm logged in to the Adjust dashboard and I see a "Firefox Android Beta" product (sibling to "Firefox Android and iOS").  I expect you'll be taking that appid.

releng (coop?), please name the new file /builds/adjust-sdk-beta.token or similar, to differentiate from the existing file.  (See https://dxr.mozilla.org/mozilla-central/source/mobile/android/config/mozconfigs/common#52.)

Aside: why is "Firefox Android and iOS" potentially lumping these two different products together?  Am I looking at the wrong dashboard?

coop: can you drive or delegate this?  It's not a fire drill but it is very high priority: mobile team's data drop has shown that we need to split this bucket to witness problems in beta before they hit release.
Depends on: 1152871
Flags: needinfo?(coop)
Summary: Put Beta under a separate app ID in Adjust → Add releng build file containing Adjust SDK private app token for Beta builds
Tracking this for 45+ since this sounds like we're aiming to fix the related bugs for 45. 
Sylvestre, an extra n-i so you notice this.
Flags: needinfo?(sledru)
Nick, I'll be handling this for releng.

Once I have the key I'll work on this, ETA no more than +1 day from receipt of key.

You can also gpg directly to me if you like, (send as an encrypted attachment not an encrypted mail please): http://gpg.mozilla.org/pks/lookup?search=0x104BF9E2&fingerprint=on&op=vindex is me
Beta token keyfile, encrypted to the key at http://gpg.mozilla.org/pks/lookup?search=0x104BF9E2&fingerprint=on&op=vindex and to my own personal key.
Flags: needinfo?(coop)
Comment on attachment 8717636 [details]
adjust-sdk-beta.token.asc

Added this secret to puppet as |secret('adjust_sdk_beta_token')| working on patches now
Attachment #8717649 - Flags: review?(hwine)
Attachment #8717653 - Flags: review?(hwine)
Comment on attachment 8717649 [details] [diff] [review]
[puppet] add beta adjust token

Review of attachment 8717649 [details] [diff] [review]:
-----------------------------------------------------------------

lrtm
Attachment #8717649 - Flags: review?(hwine) → review+
Comment on attachment 8717653 [details] [diff] [review]
[buildbot-configs] copy token into mock

Review of attachment 8717653 [details] [diff] [review]:
-----------------------------------------------------------------

lrtm
Attachment #8717653 - Flags: review?(hwine) → review+
Comment on attachment 8717654 [details] [diff] [review]
[mozilla-central] copy into mock environment (mozharness configs)

Review of attachment 8717654 [details] [diff] [review]:
-----------------------------------------------------------------

lrtm
Attachment #8717654 - Flags: review?(hwine) → review+
nick, my m-c patch will need to land on any branches where this is needed, along with any other changes. If there are conflicts I can help resolve them though. Beyond that we should be good to go, after the next releng "reconfig".
(In reply to Justin Wood (:Callek) from comment #14)
> nick, my m-c patch will need to land on any branches where this is needed,
> along with any other changes. If there are conflicts I can help resolve them
> though. Beyond that we should be good to go, after the next releng
> "reconfig".

Great!  How do I track this reconfigure?
Flags: needinfo?(bugspam.Callek)
(In reply to Nick Alexander :nalexander from comment #15)
> (In reply to Justin Wood (:Callek) from comment #14)
> > nick, my m-c patch will need to land on any branches where this is needed,
> > along with any other changes. If there are conflicts I can help resolve them
> > though. Beyond that we should be good to go, after the next releng
> > "reconfig".
> 
> Great!  How do I track this reconfigure?

Our scripts should post to this bug (if we do it the normal way). I'll touch back here tomorrow to verify that we either did reconfig and it was posted to this bug, or if we didn't to do it myself and get it posted to this bug.  (we likely are fine for m-c/try with my patch anyway, since puppets change is live, but I like to be sure with every patch I did deployed before I say with 100% confidence)
Flags: needinfo?(bugspam.Callek)
in production
https://hg.mozilla.org/mozilla-central/rev/f81f4e92f023
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Justin, do we need to uplift something here? thanks
Flags: needinfo?(sledru) → needinfo?(bugspam.Callek)
(In reply to Justin Wood (:Callek) from comment #8)
> Created attachment 8717654 [details] [diff] [review]
> [mozilla-central] copy into mock environment (mozharness configs)

(In reply to Sylvestre Ledru [:sylvestre] from comment #19)
> Justin, do we need to uplift something here? thanks

If this is to be used on any version not 47 or later (e.g. current aurora is 46) then yes, this patch will need to be uplifted.

I don't claim to know much about the adjust token, what its used for, or reason/plans for this patch - other than that it was important for the mobile team. I'm going to redirect the n-i to nick for your underlying question, you can clear it if this comment answers your need.
Flags: needinfo?(bugspam.Callek) → needinfo?(nalexander)
(In reply to Justin Wood (:Callek) from comment #20)
> (In reply to Justin Wood (:Callek) from comment #8)
> > Created attachment 8717654 [details] [diff] [review]
> > [mozilla-central] copy into mock environment (mozharness configs)
> 
> (In reply to Sylvestre Ledru [:sylvestre] from comment #19)
> > Justin, do we need to uplift something here? thanks
> 
> If this is to be used on any version not 47 or later (e.g. current aurora is
> 46) then yes, this patch will need to be uplifted.
> 
> I don't claim to know much about the adjust token, what its used for, or
> reason/plans for this patch - other than that it was important for the
> mobile team. I'm going to redirect the n-i to nick for your underlying
> question, you can clear it if this comment answers your need.

Yes, we would like to have access to this token all the way up to Beta (Firefox 45) today.

I have requested Bug 1248066 in the works, and will be requesting uplift to Firefox 45 when that lands.
Flags: needinfo?(nalexander)
Assignee: michael.l.comella → bugspam.Callek
Any progress here? We are shipping 45 soon.
Flags: needinfo?(bugspam.Callek)
I'm redirecting n-i to nick.

The releng work for providing the special token is in place on the systems. And the code to move it into a spot the build system can find it is also in place in mozharness. Nick needs to have the mozharness code uplifted as necessary. I'm not quite in the loop on the status there.

As far as I am concerned we're good, but nick would know best.
Flags: needinfo?(bugspam.Callek) → needinfo?(nalexander)
Liz, Callek -- sorry for the radio silence.  I don't think I'll be able to push this forward before the merge.  That's fine; we've addressed the critical issue and can mop up these bits in the next release.
Flags: needinfo?(nalexander)
Does that mean we are still aiming this for 46 beta, but only after the merge? Or, for 47 beta?
(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #25)
> Does that mean we are still aiming this for 46 beta, but only after the
> merge? Or, for 47 beta?

Whenever I can get to it, I guess.  It's riding trains and that may be fast enough.
Hi Nick, no pressure, but do you want to do this for 46? If not, let's go ahead and wontfix it for 46.
Flags: needinfo?(nalexander)
Wontfix for 46 as we are now late in the beta cycle.
I believe the token is available everywhere.  I've redirected the ticket tracking using the token (Bug 1248066) back to margaret.  Sorry for not moving on this faster.
Flags: needinfo?(nalexander)
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.