1245333 - [gui] Mozregression chooses wrong build for retry if before that I chose different build after skipping

Status: RESOLVED FIXED

(Testing :: mozregression, defect)

Description

[arni2033]

Attachment: 2015.12.31 03-18-49.png

Mozregression GUI version 0.8.1   using mozregression version 2.2.1

STR:
1. Start new bisection between 2010-01-01 and 2010-01-05 (firefox)
  (This is also reproducible with 2016 builds, but those from 2010 are just lightweight)
2. When 2010-01-03 starts, choose "Skip" and click "Evaluate"
3. When popup window appears, DoubleClick build 2010-01-02
  (Make sure that mozregression GUI suggested build 2010-01-04, and selected it with blue)
4. When 2010-01-02 starts, choose "Retry" and click "Evaluate"

AR: mozregression launches 2010-01-04 for testing, and that is displayed in "Bisection progress"
ER: mozregression should launch 2010-01-02 again, and reflect that in "Bisection progress"

Note:
 I'm attaching a screenshot with the same scenario (when I first encountered it).
 I can make another screenshot for STR above, but I hope it's pretty clear.

Comment 1

[Julien Pagès (:parkouss)]

(In reply to arni2033 from comment #0)
> Note:
>  I'm attaching a screenshot with the same scenario (when I first encountered
> it).
>  I can make another screenshot for STR above, but I hope it's pretty clear.

This is perfectly clear, thanks! I just reproduced it, and I'm fixing the issue.

Comment 2

[Julien Pagès (:parkouss)]

Attachment: gui retry error

Mikeling, if you have the time, can you look at this ?

If you don't, or for any other reason you can still pass the r? flag to wlach.

Thanks!

Comment 3

[MikeLing]

Comment on attachment 8715264 [details] [review]
gui retry error

Sorry for the late reply, it's Spring Festival in China recently:)

It looks perfect to me. r+ for this. Thank you Julien

Comment 4

[Julien Pagès (:parkouss)]

Thanks Mike!

Landed in https://github.com/mozilla/mozregression/commit/1a68a899bc796ade9e31ad5976dfda1b0695fe8b.