Closed
Bug 1245337
Opened 8 years ago
Closed 8 years ago
Intermittent e10s browser_webconsole_bug_613642_maintain_scroll.js | Uncaught exception - at :0 - Error: operation not possible on dead CPOW
Categories
(DevTools :: Console, defect, P1)
DevTools
Console
Tracking
(e10s+, firefox48 fixed, firefox49 fixed, firefox50 fixed)
RESOLVED
FIXED
Firefox 50
People
(Reporter: philor, Assigned: moby)
References
(Blocks 1 open bug)
Details
(Keywords: intermittent-failure, Whiteboard: [btpp-backlog][console-rewrite-fix])
Attachments
(1 file, 1 obsolete file)
2.35 KB,
patch
|
bgrins
:
review+
|
Details | Diff | Splinter Review |
Updated•8 years ago
|
Blocks: e10s-tests
tracking-e10s:
--- → +
Comment 2•8 years ago
|
||
We will probably rewrite this as part of the console output rewrite.
Whiteboard: [btpp-backlog] → [btpp-backlog][console-rewrite-fix]
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → mvonbriesen
Assignee | ||
Comment 6•8 years ago
|
||
Attachment #8760957 -
Flags: review?(bgrinstead)
Comment 7•8 years ago
|
||
Comment on attachment 8760957 [details] [diff] [review] browser_webconsole_bug_613642_maintain_scroll.patch Review of attachment 8760957 [details] [diff] [review]: ----------------------------------------------------------------- ::: devtools/client/webconsole/test/browser_webconsole_bug_613642_maintain_scroll.js @@ +18,5 @@ > let scrollBox = hud.ui.outputWrapper; > > for (let i = 0; i < 150; i++) { > + ContentTask.spawn(gBrowser.selectedBrowser, null, > + "() => content.console.log('test message " + i + "')"); This won't work the same as it used to - 'i' needs to be passed into ContentTask for the string to be able to access it as an argument. See https://wiki.mozilla.org/Electrolysis/e10s_test_tips#ContentTask
Attachment #8760957 -
Flags: review?(bgrinstead)
Assignee | ||
Comment 8•8 years ago
|
||
Not sure if I did this correctly, so please let me know if I need to change something.
Attachment #8760969 -
Flags: review?(bgrinstead)
Assignee | ||
Comment 9•8 years ago
|
||
Forgot to mark the other patch as obsolete. Is there a way to do this after the fact?
Comment 10•8 years ago
|
||
Comment on attachment 8760969 [details] [diff] [review] browser_webconsole_bug_613642_maintain_scroll.patch Review of attachment 8760969 [details] [diff] [review]: ----------------------------------------------------------------- Yeah, looks right to me. You could also check this in the test by 'pausing' the task with `yield new Promise(r=>r)` and then opening up the page's web console to make sure it's logging correctly. Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=97e42d2d640b
Attachment #8760969 -
Flags: review?(bgrinstead) → review+
Comment 11•8 years ago
|
||
(In reply to Maximillian von Briesen [:moby] from comment #9) > Forgot to mark the other patch as obsolete. Is there a way to do this after > the fact? You can click 'Details' -> 'edit details' then check obsolete
Assignee | ||
Updated•8 years ago
|
Attachment #8760957 -
Attachment is obsolete: true
Comment 12•8 years ago
|
||
bc1 failures in the try push look like a side effect of mach try
Keywords: checkin-needed
Comment hidden (Intermittent Failures Robot) |
Comment 14•8 years ago
|
||
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/fx-team/rev/70078e65fa4f Fix content.console.log statements in browser_webconsole_bug_613642_maintain_scroll.js; r=bgrins
Keywords: checkin-needed
Comment 15•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/70078e65fa4f
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Comment hidden (Intermittent Failures Robot) |
Comment 17•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/4e748c85cb42
status-firefox49:
--- → fixed
Comment 18•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/6941d20b7382
status-firefox48:
--- → fixed
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•