Closed Bug 1245337 Opened 4 years ago Closed 3 years ago

Intermittent e10s browser_webconsole_bug_613642_maintain_scroll.js | Uncaught exception - at :0 - Error: operation not possible on dead CPOW

Categories

(DevTools :: Console, defect, P1)

defect

Tracking

(e10s+, firefox48 fixed, firefox49 fixed, firefox50 fixed)

RESOLVED FIXED
Firefox 50
Tracking Status
e10s + ---
firefox48 --- fixed
firefox49 --- fixed
firefox50 --- fixed

People

(Reporter: philor, Assigned: moby)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure, Whiteboard: [btpp-backlog][console-rewrite-fix])

Attachments

(1 file, 1 obsolete file)

Blocks: e10s-tests
tracking-e10s: --- → +
1 total, 0 in the last month.
Priority: -- → P3
Whiteboard: [btpp-backlog]
We will probably rewrite this as part of the console output rewrite.
Whiteboard: [btpp-backlog] → [btpp-backlog][console-rewrite-fix]
Bumping to P1, this has become much more frequent
Priority: P3 → P1
Assignee: nobody → mvonbriesen
Attachment #8760957 - Flags: review?(bgrinstead)
Comment on attachment 8760957 [details] [diff] [review]
browser_webconsole_bug_613642_maintain_scroll.patch

Review of attachment 8760957 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/webconsole/test/browser_webconsole_bug_613642_maintain_scroll.js
@@ +18,5 @@
>    let scrollBox = hud.ui.outputWrapper;
>  
>    for (let i = 0; i < 150; i++) {
> +    ContentTask.spawn(gBrowser.selectedBrowser, null,
> +      "() => content.console.log('test message " + i + "')");

This won't work the same as it used to - 'i' needs to be passed into ContentTask for the string to be able to access it as an argument.  See https://wiki.mozilla.org/Electrolysis/e10s_test_tips#ContentTask
Attachment #8760957 - Flags: review?(bgrinstead)
Not sure if I did this correctly, so please let me know if I need to change something.
Attachment #8760969 - Flags: review?(bgrinstead)
Forgot to mark the other patch as obsolete. Is there a way to do this after the fact?
Comment on attachment 8760969 [details] [diff] [review]
browser_webconsole_bug_613642_maintain_scroll.patch

Review of attachment 8760969 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, looks right to me.  You could also check this in the test by 'pausing' the task with `yield new Promise(r=>r)` and then opening up the page's web console to make sure it's logging correctly.  Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=97e42d2d640b
Attachment #8760969 - Flags: review?(bgrinstead) → review+
(In reply to Maximillian von Briesen [:moby] from comment #9)
> Forgot to mark the other patch as obsolete. Is there a way to do this after
> the fact?

You can click 'Details' -> 'edit details' then check obsolete
Attachment #8760957 - Attachment is obsolete: true
bc1 failures in the try push look like a side effect of mach try
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/70078e65fa4f
Fix content.console.log statements in browser_webconsole_bug_613642_maintain_scroll.js; r=bgrins
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/70078e65fa4f
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.