Closed
Bug 1245383
Opened 9 years ago
Closed 9 years ago
Intermittent e10s browser_scratchpad_execute_print.js | uncaught exception - Error: unsafe CPOW usage forbidden at :0
Categories
(DevTools Graveyard :: Scratchpad, defect)
DevTools Graveyard
Scratchpad
Tracking
(e10s+, firefox48 fixed)
RESOLVED
FIXED
Firefox 48
People
(Reporter: philor, Assigned: pbro)
References
(Blocks 1 open bug)
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
Reporter | ||
Updated•9 years ago
|
Summary: Intermittent browser_scratchpad_execute_print.js | uncaught exception - Error: unsafe CPOW usage forbidden at :0 → Intermittent e10s browser_scratchpad_execute_print.js | uncaught exception - Error: unsafe CPOW usage forbidden at :0
Updated•9 years ago
|
Blocks: e10s-tests
tracking-e10s:
--- → +
Comment 1•9 years ago
|
||
Not sure who owns Scratchpad these days. Joe, can you help find an owner for this please?
Flags: needinfo?(jwalker)
Assignee | ||
Comment 2•9 years ago
|
||
I'll take a look at this one. My fix is to remove usage of 'content' in the test and use ContentTask.spawn instead to access the content page.
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
Flags: needinfo?(jwalker)
Assignee | ||
Comment 3•9 years ago
|
||
browser_scratchpad_contexts.js and browser_scratchpad_execute_print.js used to
access javascript properties on the content window object by using 'content.'
directly.
Now these tests use 'ContentTask.spawn' instead, which required the
runAsyncCallbackTests helper to be changed so it would use a Task and yield
on the promises returned by prepare and then.
Review commit: https://reviewboard.mozilla.org/r/38195/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/38195/
Attachment #8726711 -
Flags: review?(poirot.alex)
Assignee | ||
Comment 4•9 years ago
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8726711 [details]
MozReview Request: Bug 1245383 - Use ContentTask.spawn to access the content window in 2 scratchpad tests; r=ochameau
https://reviewboard.mozilla.org/r/38195/#review34685
Thanks for cleaning everything...
Note that's my last review, I'm going on PTO until 14th.
::: devtools/client/scratchpad/test/head.js:206
(Diff revision 1)
> + return ContentTask.spawn(browser, args, generator);
It looks like you never use the two last arguments.
Shouldn't we just remove them?
Did you copied this method from somewhere?
Shouldn't we just share-import it from shared-head or something?
Attachment #8726711 -
Flags: review?(poirot.alex) → review+
Assignee | ||
Comment 6•9 years ago
|
||
(In reply to Alexandre Poirot [:ochameau] PTO, back on 14th from comment #5)
> It looks like you never use the two last arguments.
> Shouldn't we just remove them?
Right, I'll remove them
> Did you copied this method from somewhere?
No
> Shouldn't we just share-import it from shared-head or something?
I'd rather not because that means importing shared-head.js in head.js, because it's not there yet, and therefore maybe cleaning duplicated functions a bit, so, spending more time on this than scratchpad deserves right now.
Comment 8•9 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Updated•7 years ago
|
Product: Firefox → DevTools
Updated•5 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•