1245502 - Would be nice to see the container for each tab in about:sessionrestore

Status: NEW

(Firefox :: Session Restore, enhancement, P3)

Description

[Andrea Marchesini [:baku]]

Currently we show just the url/title but would be nice to see also the name of the container where such tabs have been loaded into.

Comment 1

[Andrea Marchesini [:baku]]

Bram, here an use-case: I have 2 tabs, both with facebook webiste in 2 different contains. Then something bad happens and I have to restart FF. What I see is about:sessionrestore where I see a table showing my 2 facebook tabs ready to be restored.
The current UI shows just the title of the tab, but it's not possible to see which containers they will run into. To me that seems confusing. In particular it's impossible to choose to restore only 1 of those 2 facebook tabs because I don't see which container I'm going to restore.

What I propose is to add a new column called 'containers'. I would show this column only if at least 1 of the tabs was running in a particular container. Feedback?

Comment 2

[Bram Pitoyo [:bram]]

Attachment: containers - session restore indicator - i01

What about showing container name, icon and colour to the right side of each row containing container tab? It’ll have the same font size as the rest of the table text.

A visual exception applies when you highlight the row, as the icon and font will both turn white.

Comment 3

[Tanvi Vyas[:tanvi]]

Comment on attachment 8715498 [details]
containers - session restore indicator - i01

This looks nice Bram!

Comment 4

[Bram Pitoyo [:bram]]

Thank you!

The only concern I have left concerns adding a new xul:treecol element specifically for Containers, and how that might break the layout when the window is resized too narrowly. We’ll have to make sure that it looks okay when implemented, and I think it’s good to go.

Comment 5

[Andrea Marchesini [:baku]]

I don't think it's possible to do it with XUL css (or I don't know how to do it). Bram any help here?

Comment 6

[Andrea Marchesini [:baku]]

Attachment: c.patch

This is a simple test I wrote. We can play with CSS following the userContextId value, but from there to what Bram proposes, there is a huge gap :)

Comment 7

[Bram Pitoyo [:bram]]

(In reply to Andrea Marchesini (:baku) from comment #5)
> I don't think it's possible to do it with XUL css (or I don't know how to do
> it). Bram any help here?

Sorry. I don’t know how to fiddle with XUL and do this, either.

Comment 8

[Andrea Marchesini [:baku]]

Paolo, can you help me with this?

Comment 9

[:Paolo Amadini]

Actually, I don't think we should spend time on this at this stage of feature development. As far as I can tell we're doing some minimal UI to help with developing platform features and with user testing. Losing the session hopefully won't occur during user testing :-)

Tanvi, what do you think?

Comment 10

[Tanvi Vyas[:tanvi]]

(In reply to :Paolo Amadini from comment #9)
> Actually, I don't think we should spend time on this at this stage of
> feature development. As far as I can tell we're doing some minimal UI to
> help with developing platform features and with user testing. Losing the
> session hopefully won't occur during user testing :-)
> 
> Tanvi, what do you think?

It's not the highest priority, but if baku has the time and incentive to fix this now, then why wait?

baku, can you provide a screenshot of what your current patch does?  Maybe that is good enough for now, to communicate to the user what context the tab will load in, without making the UI as pretty as Bram has done.  We can file a bug for enhancements and do that after v1.

Comment 11

[Bram Pitoyo [:bram]]

Let me know if there’s anything I can provide by way of visuals. Since it will most likely not take too much time away from other projects, I will be happy to devote some time to produce it.

Comment 12

[Firefox Bug Husbandry Bot]

Bulk change per https://bugzilla.mozilla.org/show_bug.cgi?id=1401020

Comment 13

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is relatively low, S3. However, the bug has 23 votes.
:dao, could you consider increasing the bug severity?

For more information, please visit auto_nag documentation.