1245505 - Last sync date not localized in synced tabs button tooltip

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Stefan Plewako [:stef]]

https://hg.mozilla.org/releases/mozilla-beta/file/default/services/sync/locales/en-US/sync.properties#l9

OS X 10.11, Firefox 45.0b2 pl
Currently: "Ostatnia synchronizacja: Wed 15:55"
Should be: "Ostatnia synchronizacja: środa, 15:55" (or something similar)

Apart from not being localized this could also mislead and confuse users even more when there are short weekday names collisions between installed locale and English.

Comment 1

[Edouard Oger [:eoger]]

Attachment: bug-1245505.patch

Let's use something more standard than toLocaleFormat.

Comment 2

[Stefan Plewako [:stef]]

(In reply to Edouard Oger [:eoger] from comment #1)
> Let's use something more standard than toLocaleFormat.

Yes, that would work (see also bug 409832 comment 10) but could we please use normal ("long") form for the weekday as we do not really have a need to shorten it?

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8715329 [details] [diff] [review]
bug-1245505.patch

Review of attachment 8715329 [details] [diff] [review]:
-----------------------------------------------------------------

Edouard's back! \o/

LGTM, but please change the weekday to "long" as mentioned in comment 2

Comment 4

[Edouard Oger [:eoger]]

Attachment: bug-1245505.patch

Here we go, with the long weekday. Carrying r+ forward.
Nice to see too Mark!

Comment 5

[Edouard Oger [:eoger]]

Attachment: bug-1245505.patch

Nitpick I forgot a semicolon

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/d0badf8b22b0

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/d0badf8b22b0