44 bytes, text/x-github-pull-request
|Details | Review | Splinter Review|
Supposedly, the PolyCrashStorage class writes to a list of destinations, and if one of them fails, it's supposed to still write to the others. While failing to switch our ES clusters, we realized that it was failing at writing to other stores. We'll want to have some form of test that covers this case. Here's a scenario: 1. storage0 passes 2. storage1 fails 3. storage2 should be attempted and pass 4. an error is raised and the job is marked as failing (and should be retried later on) At the moment, storage2 is never even attempted.
Created attachment 8715407 [details] [review] Link to Github pull-request: https://github.com/mozilla/socorro/pull/3183
Commit pushed to master at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/877850109804124ba010dac6d8d743d7259592f0 Fixes bug 1245558 - Added failures handling to save_raw_and_processed method of PolyCrashStorage class. r=peterbe
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.