1245605 - Thunderbird beta release source builder failing to run configure

Status: VERIFIED FIXED

(Release Engineering :: Release Automation, defect)

Description

[Wayne Mery (:wsmwk)]

+++ This bug was initially created as a clone of Bug #1243448 +++

jlund investigated.
Turns out we can't limp through a beta without this for Thunderbird. 
Because if this we're missing builders AV, checksums, etc 
ref: https://www.lucidchart.com/documents/view/b733c8be-e607-445f-824a-f3353c287294

gaston	21:06 < gaston > i dont know the releng details but maybe c-b needs a 'dumb' mozconfig like https://bug1243448.bmoattachments.org/attachment.cgi?id=8714413
gaston	21:08 < gaston > in (wild guess) mail/config/mozconfigs/linux64/source ?

Callek	jlund: howd we fix it for firefox?
Callek	jlund: I thought we did source after-the-push for it?
jlund	I think nthomas ended up forcing a checksums push that triggered things downstreams. though the order there is important
jlund	we then fixed the source builder for real which triggered jobs again.
jlund	Callek: it's better to fix the source builder I think. can we just land and retag your source mozconfig. is that the only blocker?
Callek	`probably`
Callek	it needs to land in a mail/ dir at least

Comment 1

[aleth [:aleth]]

Attachment: Add 'dumb' source mozconfig (port Bug 1243448 - beta release source builder failing to run configure)

This is is a straight port and should land only on beta for now.

Comment 2

[aleth [:aleth]]

I suspect the equivalent of https://hg.mozilla.org/build/buildbot-configs/rev/8b8b715b6951 will also be needed.

Comment 3

[aleth [:aleth]]

Attachment: Use 'dumb' source mozconfig for TB beta builds following bug 123448

Unlike https://hg.mozilla.org/build/buildbot-configs/rev/8b8b715b6951, the buildbot config already had a source_mozconfig entry here. I don't know if that was doing any important work which will break if it's replaced by this.

Comment 4

[aleth [:aleth]]

Attachment: Use 'dumb' source mozconfig for TB beta builds following bug 123448

Forgot staging.

Comment 5

[Kent James (:rkent)]

Adding Magnus in case he wants to comment on the configuration change.

I assume that the intention is to port this to beta? Is it beta-only, or on comm-central as well for now? I don't see that the FF equivalent has been added to mozilla-beta, or is that coming soon?

Comment 6

[aleth [:aleth]]

(In reply to Kent James (:rkent) from comment #5)
> I assume that the intention is to port this to beta? Is it beta-only, or on
> comm-central as well for now? I don't see that the FF equivalent has been
> added to mozilla-beta, or is that coming soon?

This has landed on m-b: https://hg.mozilla.org/releases/mozilla-beta/log/tip/browser/config/mozconfigs/linux64/source

Comment 7

[aleth [:aleth]]

(In reply to aleth [:aleth] from comment #6)
> (In reply to Kent James (:rkent) from comment #5)
> > I assume that the intention is to port this to beta? Is it beta-only, or on
> > comm-central as well for now? 

Since it's on m-c as well, comment 1 is wrong and we should land it on c-c too. What is unclear to me is which buildbot-config files should ultimately refer to it (e.g. thunderbird_*.py ?).

Comment 8

[Kent James (:rkent)]

Comment on attachment 8715474 [details] [diff] [review]
Add 'dumb' source mozconfig (port Bug 1243448 - beta release source builder failing to run configure)

OK I think I understand this well enough to be comfortable adding this.

Comment 9

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/72e817a0f26cbca44d06ab1936e935946f2d5083
Bug 1245605 - Add 'dumb' source mozconfig (port Bug 1243448 - beta release source builder failing to run configure). r=rkent a=me CLOSED TREE DONTBUILD

Comment 10

[aleth [:aleth]]

https://hg.mozilla.org/releases/comm-aurora/rev/e4b79af8a54b49d2e5142d135f4818cb44fa40a7
Bug 1245605 - Add 'dumb' source mozconfig (port Bug 1243448 - beta release source builder failing to run configure). r=rkent a=aleth

Comment 11

[aleth [:aleth]]

https://hg.mozilla.org/releases/comm-beta/rev/e2692503df3187aa87940cb34425828a2a593526
Bug 1245605 - Add 'dumb' source mozconfig (port Bug 1243448 - beta release source builder failing to run configure). r=rkent a=aleth

Comment 12

[Justin Wood (:Callek)]

Comment on attachment 8715474 [details] [diff] [review]
Add 'dumb' source mozconfig (port Bug 1243448 - beta release source builder failing to run configure)

Review of attachment 8715474 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the late notice, but I think we also want:

http://mxr.mozilla.org/comm-central/source/mail/config/mozconfigs/linux32/debug#21

(the two client.py things) added, otherwise the tarball/checked-out-code won't include mozilla-*

Comment 13

[aleth [:aleth]]

Attachment: Followup to add client.py to the source mozconfig

Comment 14

[aleth [:aleth]]

Comment on attachment 8715505 [details] [diff] [review]
Followup to add client.py to the source mozconfig

rs+ Callek over IRC.

Comment 15

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/fa68d82ce36b192d6458e3ab321041fb768ed913
Bug 1245605 - Followup to add client.py to the source mozconfig. rs=Callek a=aleth CLOSED TREE DONTBUILD

Comment 16

[aleth [:aleth]]

https://hg.mozilla.org/build/buildbot-configs/rev/22f1e00d700ce1961ec8180dc9607ffd278631a3
Bug 1245605 - Use 'dumb' source mozconfig for TB beta builds following bug 123448. r=jlund

Comment 17

[aleth [:aleth]]

https://hg.mozilla.org/releases/comm-aurora/rev/979006bb04f213907ada6906d6bf189a9cf5255e
Bug 1245605 - Followup to add client.py to the source mozconfig. rs=Callek a=aleth

Comment 18

[aleth [:aleth]]

https://hg.mozilla.org/releases/comm-beta/rev/f0fc8eb8187ce6f2d618013ef5f1433f32c42b23
Bug 1245605 - Followup to add client.py to the source mozconfig. rs=Callek a=aleth

Comment 19

[Release Engineering SlaveAPI Service]

In production: https://hg.mozilla.org/build/buildbot-configs/rev/22f1e00d700c