1245671 - browser_ext_browserAction_pageAction_icon.js and browser_ext_pageAction_popup.js are going to permafail when Gecko 47 merges to Beta

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

[Tracking Requested - why for this release]: Merge day permafail when Gecko 47 hits Beta.

Tests depending on something that's ifndef RELEASE_BUILD presumably.

https://treeherder.mozilla.org/logviewer.html#?job_id=16252360&repo=try

 23:00:24     INFO -  131 INFO Entering test testSecureManifestURLsDenied
 23:00:24     INFO -  132 INFO TEST browser_action icon url: chrome://browser/content/browser.xul
 23:00:24     INFO -  133 INFO Extension loaded
 23:00:24     INFO -  134 INFO Console message: Security Error: Content at moz-extension://96b28bc2-a9fd-4f40-a880-b6cd93e91bc6/ may not load or link to chrome://browser/content/browser.xul.
 23:00:24     INFO -  135 INFO Console message: Security Error: Content at moz-extension://96b28bc2-a9fd-4f40-a880-b6cd93e91bc6/ may not load or link to chrome://browser/content/browser.xul.
 23:00:24     INFO -  136 INFO TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_browserAction_pageAction_icon.js | Uncaught exception - at resource://testing-common/Assert.jsm:112 - TypeError: stack is null
 23:00:24     INFO -  Stack trace:
 23:00:24     INFO -      Assert.AssertionError@resource://testing-common/Assert.jsm:112:1
 23:00:24     INFO -      proto.report@resource://testing-common/Assert.jsm:183:13
 23:00:24     INFO -      proto.rejects/</<@resource://testing-common/Assert.jsm:389:9
 23:00:24     INFO -      Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:937:23
 23:00:24     INFO -      this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:816:7
 23:00:24     INFO -      this.PromiseWalker.scheduleWalkerLoop/<@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:750:11
 23:00:24     INFO -      Tester_execTest@chrome://mochikit/content/browser-test.js:803:9
 23:00:24     INFO -      Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:723:7
 23:00:24     INFO -      SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:741:59
 23:00:24     INFO -  137 INFO Leaving test testSecureManifestURLsDenied
 23:00:24     INFO -  monitorConsole | [0] matched {"message":"[JavaScript Error: \"1454482822849\taddons.webextension.<unknown>\tERROR\tLoading extension 'null': Reading manifest: Error processing browser_action.default_icon: Error processing browser_action.default_icon: SyntaxError: String \"chrome://browser/content/browser.xul\" must be a relative URL\" {file: \"resource://gre/modules/Log.jsm\" line: 751}]","errorMessage":"1454482822849\taddons.webextension.<unknown>\tERROR\tLoading extension 'null': Reading manifest: Error processing browser_action.default_icon: Error processing browser_action.default_icon: SyntaxError: String \"chrome://browser/content/browser.xul\" must be a relative URL","sourceName":"resource://gre/modules/Log.jsm","sourceLine":"","lineNumber":751,"columnNumber":0,"category":"XPConnect JavaScript","windowID":0,"isScriptError":true,"isWarning":false,"isException":false,"isStrict":false}
 23:00:24     INFO -  138 INFO Console message: [JavaScript Error: "1454482822849	addons.webextension.<unknown>	ERROR	Loading extension 'null': Reading manifest: Error processing browser_action.default_icon: Error processing browser_action.default_icon: SyntaxError: String "chrome://browser/content/browser.xul" must be a relative URL" {file: "resource://gre/modules/Log.jsm" line: 751}]
 23:00:24     INFO -  MEMORY STAT | vsize 633MB | residentFast 199MB | heapAllocated 104MB

 23:00:44     INFO -  178 INFO Entering test testPageActionSecurity
 23:00:44     INFO -  179 INFO TEST browser_action icon url: chrome://browser/content/browser.xul
 23:00:44     INFO -  180 INFO Extension loaded
 23:00:44     INFO -  181 INFO TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_pageAction_popup.js | Uncaught exception - at resource://testing-common/Assert.jsm:112 - TypeError: stack is null
 23:00:44     INFO -  Stack trace:
 23:00:44     INFO -      Assert.AssertionError@resource://testing-common/Assert.jsm:112:1
 23:00:44     INFO -      proto.report@resource://testing-common/Assert.jsm:183:13
 23:00:44     INFO -      proto.rejects/</<@resource://testing-common/Assert.jsm:389:9
 23:00:44     INFO -      Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:937:23
 23:00:44     INFO -      this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:816:7
 23:00:44     INFO -      this.PromiseWalker.scheduleWalkerLoop/<@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:750:11
 23:00:44     INFO -      Tester_execTest@chrome://mochikit/content/browser-test.js:803:9
 23:00:44     INFO -      Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:723:7
 23:00:44     INFO -      SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:741:59
 23:00:44     INFO -  182 INFO Leaving test testPageActionSecurity

Comment 1

[Kris Maglione [:kmag]]

Hm. This looks like a bug in Assert.jsm. It seems to be assuming it'll eventually hit a stack frame that isn't in Assert.jsm, which I guess doesn't happen from a promise callback in release builds.

I'm surprised other tests aren't failing for the same reason, though.

Comment 2

[Kris Maglione [:kmag]]

I guess it's probably because we use DOM promises rather than Promise.jsm promises, only the latter of which create a JS stack frame before calling the handler.

Comment 3

[Kris Maglione [:kmag]]

Attachment: MozReview Request: Bug 1245671: Fix Assert.rejects on release builds with DOM promises. r?markh

Review commit: https://reviewboard.mozilla.org/r/33717/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33717/

Comment 4

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8716113 [details]
MozReview Request: Bug 1245671: Fix Assert.rejects on release builds with DOM promises. r?markh

https://reviewboard.mozilla.org/r/33717/#review30427

Comment 5

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/fx-team/rev/75c21c179b63e364b42b123e24f12417c4f14539
Bug 1245671: Fix Assert.rejects on release builds with DOM promises. r=markh

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8716113 [details]
MozReview Request: Bug 1245671: Fix Assert.rejects on release builds with DOM promises. r?markh

Looks good on Try.

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/75c21c179b63